about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2024-11-03 r/8885 fix(tvix/nix-compat-derive-tests) More enum testsBrian Olsen1-6/+65
Before this commit only deriving of tuple enums where tested. This adds a few tests to cover the other types of enums. Change-Id: I62f311e4db98cab84bd4ac164d50051e9aab0d4d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12725 Autosubmit: Brian Olsen <me@griff.name> Reviewed-by: Vladimir Kryachko <v.kryachko@gmail.com> Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-11-03 r/8884 chore(tvix/docs): Small changes to Nix Daemon protocol descriptionBrian Olsen5-14/+15
I found some more operations that are obsolete and a few missing fields. I also did some small changes to make handshake description more consistent. Change-Id: I9f853a37e9d50621491f31ea71879d6a600046e2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12724 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-11-02 r/8883 docs(tvix/TODO): add Value::Json TODOFlorian Klink1-0/+9
Change-Id: Id47c1e3f98cb0bf53006b002417b69cfa49b7410 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12721 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
2024-11-02 r/8882 feat(tvix/glue): use InvalidHash for builtins.pathBob van der Linden1-10/+1
Previously such errors showed up as: error[E006]: expected value of type 'sha256', but found a 'not a sha256' Now they show up as: error[E041]: Invalid hash: invalid encoded digest length '31' for algo sha256 This is consistent with the errors of `builtins.fetchurl`. Change-Id: Id11b26fc7951778640cc4e41b3bf23203eaf07df Reviewed-on: https://cl.tvl.fyi/c/depot/+/12719 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-11-02 r/8881 feat(tvix/eval): introduce ErrorKind::InvalidHashBob van der Linden2-2/+6
The nixhash errors were wrapped in a generic TvixError. Now it has its own TvixError with unique error code. The nixhash error is passed along as a string. The errors looked like: error[E997]: invalid encoded digest length '51' for algo sha256 Now they look like: error[E041]: Invalid hash: invalid encoded digest length '51' for algo sha256 Change-Id: I5c420815538ba4c6567c95f5d44d60c4d48f43fd Reviewed-on: https://cl.tvl.fyi/c/depot/+/12718 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-11-02 r/8880 fix(tvix/nix_compat): Fix nix-daemon handshakeVova Kryachko2-11/+66
Existing handshake behavior assumed that the server version is always at least as new as the client. Meaning that the client's version was always picked the handshake details as well as for further communication This change removes that assumption and correctly uses min(server_version, client_version). Change-Id: Ia5dad4613dd5f69a0aeb6c9d86982f1f36fe1a4c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12722 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-11-01 r/8879 fix(tvix/tracing): Enable tracing in tvix-build.Vova Kryachko3-2/+5
Change-Id: Ica9734d7774da4d5e2a5cacab6b9feb27becc3e2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12720 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-30 r/8878 feat(tvix/nix-daemon): Initial skeleton for nix-daemonVova Kryachko6-0/+213
The goal is to create a drop-in replacement nix-daemon that nix-cpp can use as a `daemon` store. Change-Id: Ie092047dcc6a24a3b8d8d1b808f3e6fd2c493bf2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12711 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-30 r/8877 refactor(tvix/tracing): drop log_level methodFlorian Klink1-24/+4
There's no more consumers left. Change-Id: I0585abbdbe0ffcf35cd20ac58077ade67cbf5c75 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12715 Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de>
2024-10-30 r/8876 refactor(tvix/build): drop log level cli argFlorian Klink1-11/+2
This does the same as cl/12585 did for tvix-cli. Change-Id: Ia2d693f5ad10feb81777c951bcd4489a3a83ad7c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12716 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
2024-10-30 r/8875 refactor(tvix/store): drop log level cli argFlorian Klink1-8/+1
This does the same as cl/12585 did for tvix-cli. Change-Id: I35215947f3616acd65654c2bbdb19d0c360b568b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12714 Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de>
2024-10-28 r/8874 chore(tvix/shell): add cargo-flamegraphsterni1-0/+1
Change-Id: I991337d6db2442b1239ca048b25f28985cfdaa05 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12706 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Autosubmit: sterni <sternenseemann@systemli.org>
2024-10-28 r/8873 chore(3p/overlays): pin niri to latest masterVincent Ambo1-0/+21
This version has my trackball fixes, and interactive move, both of which are not in a stable release yet. Change-Id: Id7356e328772c972db7fb496ac80c318e8c5b330 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12707 Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-10-27 r/8872 feat(tazjin/nixos): enable automatic-gc on all physical machinesVincent Ambo2-9/+9
Change-Id: I115c29da5d7038a5e6e917928a16a2b8c6eb084e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12692 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2024-10-27 r/8871 chore(3p/sources): bump channels & overlays (2024-10-27)Vincent Ambo1-12/+12
Change-Id: Ida2775fbfb246698dd9ca01740fc28f5785f61c1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12689 Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-10-27 r/8870 fix(ops/whitby): fix keycloak header configurationVincent Ambo1-1/+1
The copy&paste from the documentation didn't work ... Change-Id: Ic894356354d6ac2b66562da5aa89590cd94ae347 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12705 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-10-27 r/8869 fix(tvix/eval): fix unused variable warnings being invertedYureka1-1/+1
Thanks to lexi for finding this Change-Id: Ic248af55426630b5e07183e4eac1596d52954478 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12696 Tested-by: BuildkiteCI Autosubmit: yuka <yuka@yuka.dev> Reviewed-by: tazjin <tazjin@tvl.su>
2024-10-27 r/8868 fix(tvix/build): fix build on MacOSFlorian Klink1-0/+1
oci_spec::runtime::Posix* stuff is feature-flagged out on MacOS. While it might be desirable to emit Linux OCI runtime specs from MacOS to schedule there, and it being feature-flagged to Linux might be a bug in the upstream crate, we only have an implementation invoking runc, which certainly don't work. Feature-flag this out to make tvix-build and tvix-cli to build on MacOS. This can be revisited once we actually start thinking about builders on MacOS. Change-Id: I82002f6d55eddd9c305f1b3a3f3f2b252f617ed0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12694 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
2024-10-27 r/8867 fix(tvix/castore/fs): fix build for MacOSFlorian Klink1-2/+3
fuse_backend_rs::api::filesystem::Layer is not exposed for non-Linux, and feature-flagged on virtiofs, so only implement the trait for these cases. Change-Id: Id8455dc5be502f8375836ba04288d50c59d69d89 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12693 Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-27 r/8866 fix(tvix/shell): fix shell on MacOSFlorian Klink2-3/+4
runc is not available on MacOS, we only want to include it in the shell if on Linux. Point TVIX_BUILD_SANDBOX_SHELL to /bin/sh if not on Linux. While we cannot use the OCI/runc executor on MacOS, other implementations might make use of this env var, so it's good to keep setting it. Also update the other occurence of it, in tvix/utils.nix. Change-Id: If7b47e1bb7c41bbde84c93016713754a252c4355 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12691 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI
2024-10-27 r/8865 feat(users/flokli/kb/corneish_zen): initFlorian Klink4-0/+146
This builds the keyboard firmware using zmk-nix. The miryoku_zmk config is pulled in from manna-harbour/miryoku_zmk, but slightly patched to add support for RALT and quick-tap. Change-Id: I91efbbd789526cce7f086f367c7bccb7857b06e6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12695 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Autosubmit: flokli <flokli@flokli.de>
2024-10-27 r/8864 fix(tazjin/emacs): fix completion related problemsVincent Ambo2-8/+15
A while ago I decided to experiment with corfu and orderless instead of company/prescient. This was prompted by issues which I had in EXWM, where some sort of UI race with company elements could lock up a whole frame. Now that I'm not on EXWM anymore this doesn't really matter, so I can bring back company and set up prescient again correctly, fixing a whole bunch of issues along the way: * Completion issues where not all matching candidates where shown based on cursor position (I honestly have no idea what caused this and what was going on there, never figured it out, but enabling prescient properly fixes it). * Code completion works again. Corfu, as I understand it, is technically better/cleaner/whatever than company - but it doesn't work anywhere, especially not in telega.el where I need completion more than anywhere else. With this commit my Emacs behaves a lot better again. Change-Id: I8f082de8211dd3be3bb7a0663d43d414cc320e49 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12690 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su>
2024-10-27 r/8863 feat(tvix/tracing): filter indicatif.pb_show fields in all casesFlorian Klink1-1/+7
Change-Id: I688cec79cefeae340872945c35743fae892cd053 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12688 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: yuka <yuka@yuka.dev> Reviewed-by: flokli <flokli@flokli.de>
2024-10-27 r/8862 docs(tvix/TODO): add OCI preflight checksFlorian Klink1-0/+5
Change-Id: I0865487f84556932149d95902d7399b5f7037314 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12687 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: yuka <yuka@yuka.dev>
2024-10-27 r/8861 docs(tvix/build): we use stricter castore typesFlorian Klink1-2/+0
Change-Id: Ie96b4f85d46984cac2ecc50ff9b70fa0b26ae80d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12686 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: yuka <yuka@yuka.dev>
2024-10-27 r/8860 chore(3p/sources): bump channels & overlays (2024-10-23)Vincent Ambo16-533/+143
* ops/modules: remove deprecated headscale DNS setting * users/aspen: use stable julia again (upstream ticket is resolved, and 16 has been removed because it's long deprecated) * users/wpcarro: utillinux -> util-linux * 3p/overlays: temporarily restore utillinux until upstream breakage is fixed * users/tazjin: noto-cjk -> noto-cjk-sans * tvix: regenerate Go protobufs Change-Id: I9dbec812306cd4e66030d14bbea3805e8224e0d5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12679 Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: aspen <root@gws.fyi> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-10-26 r/8859 feat(users/flokli/slides/2023-asg): add pdfFlorian Klink1-0/+4
Change-Id: I85b1f2a9bb99df01546f3d0d3f60d9953f1d8d61 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12684 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-26 r/8858 fix(users/flokli/slides/2023-nixcon): fix pdf genFlorian Klink1-4/+4
reveal-md didn't exit with a nonzero exit code and just didn't contain the PDF. Fix this. Change-Id: Ie4bc7cbf4b9117b0a672a3294e9e64fb13459247 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12683 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-26 r/8857 fix(users/flokli/nixon-2024): fix pdf genFlorian Klink1-4/+4
Change-Id: I02c101fc16e4ce57d53cd423f7aa0b6a98f856df Reviewed-on: https://cl.tvl.fyi/c/depot/+/12685 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: flokli <flokli@flokli.de>
2024-10-26 r/8856 feat(users/flokli/nixon-2024): initFlorian Klink11-0/+297
Change-Id: I547a5504f6782169dd7280c0b5c21cbe66068a2e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12682 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Autosubmit: flokli <flokli@flokli.de>
2024-10-24 r/8855 refactor(tvix/build): use stricter BuildRequest typeMarijan Petričević12-175/+221
Change-Id: Ifadd190e10ec22570ab3ccb4df54f64ae5ef0a44 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12674 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-23 r/8854 chore(tvix/cli): drop direct nix-compat dependencyFlorian Klink3-6/+0
This is only using nix-compat through tvix-glue. Change-Id: Ib6391987954a28cc05a2c27c1c21585185d82d1a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12681 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI
2024-10-23 r/8853 chore(tvix/cli): drop direct castore dependencyFlorian Klink3-6/+0
This is only using tvix-castore through tvix-store. Change-Id: I342ee1e18f8c3946b712cfb446520b732091d58f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12680 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
2024-10-23 r/8852 chore(3p/sources): bump channels & overlays (2024-10-12)Vincent Ambo3-20/+17
* amend keycloak configuration as per upgrade guide for their latest, most innovative breaking changes. https://www.keycloak.org/docs/latest/upgrading/index.html#deprecated-proxy-option * users/aspen: remove deprecated noXlibs option. This option has no alternative. Change-Id: I49f45e38cda6b01ddf6f014b7b1c43972b76629f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12601 Tested-by: BuildkiteCI Reviewed-by: aspen <root@gws.fyi> Autosubmit: tazjin <tazjin@tvl.su>
2024-10-22 r/8851 fix(tazjin/dotfiles): make trackball left-handedVincent Ambo1-0/+4
... because it's on the left side! Change-Id: I1d67d797bd6137705e69b96349faa32a9c3e94ff Reviewed-on: https://cl.tvl.fyi/c/depot/+/12678 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su>
2024-10-21 r/8850 fix(tvix/glue): don't use builtins.currentSystem in testFlorian Klink1-1/+1
This test will otherwise obviously fail on aarch64-linux, or anything not x86_64-linux, as it'll produce a different Derivation. Change-Id: Iedddcb6aeff05e49fc2e6da27f08111cdc9affec Reviewed-on: https://cl.tvl.fyi/c/depot/+/12677 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI
2024-10-20 r/8849 feat(users/edef/weave): use tracing_indicatif for progressedef6-115/+1072
Progress bars :3 Change-Id: I770d0f8381521b6efc8b38c0db4d59c771887fee Reviewed-on: https://cl.tvl.fyi/c/depot/+/12673 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-19 r/8848 feat(ops/users): add marijan to usersMarijan Petričević1-0/+5
Change-Id: I2d2277915d3e679c9388ea9bc0328b4040b22bf6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12671 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8847 feat(users/edef): add .gitignore fileFlorian Klink1-0/+3
Change-Id: Ia91100f342be2b5ad6ab83bbb3844f2526ea3036 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12672 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu>
2024-10-19 r/8846 feat(users/edef/weave): use FxHashSet and dedupe earlyedef4-4/+33
Deduping early saves a fair bit of memory, but the extra hashing is costly. We switch to FxHash, since we don't need a DoS-proof hash, but we do need it to be *fast*. Change-Id: Ic6b7010874c417862baa9b882593208c8dd1d5e6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12648 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8845 feat(users/edef/weave): ingest roots in Parquet formatedef1-13/+15
Parsing of store-paths.xz is now handled by //users/edef/fetchroots. Change-Id: I78be5aada0c0a321ed79d80c9b615e5f997ac3e0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12670 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-19 r/8844 refactor(users/edef/weave/swizzle): use polars streamingedef5-112/+70
This vastly reduces the memory requirements, so we can run in ~40G RAM. Change-Id: I4952a780df294bd852a8b4682ba2fd59b9bae675 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12667 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8843 refactor(users/edef/weave): simplify OwningRef handlingedef2-32/+12
We switch to working with the underlying Arc<Bytes<u8>> type, since Buffer<u8> is already essentially an OwningRef-esque subslice. Because we're now working with an exposed Arc directly, we don't need to have our own `unsafe impl StableAddress` any more. Change-Id: I9ce2edc6899177145e15b72aa5380f708a62173c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12668 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8842 refactor(users/edef/weave): use swap rather than CASedef1-3/+5
We only care about ordering on the same variable, and we rely on the release barrier provided by rayon's thread joining. The comparison failing is always an error path, and we're indifferent about which thread it fails on. Change-Id: I592a7eaae5b6935cf424c6576a49786f39909fb6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12666 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-19 r/8841 refactor(users/edef/weave): simplify DoubleEndedIterator boundedef1-1/+1
Thanks, Clippy! Change-Id: I116b478124b72e070e94150ee850532752f64d60 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12669 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8840 fix(ops/pipelines): limit depot-nix-eval to concurrency of 3Florian Klink1-1/+1
It seems we need more memory these days, and llama frequently ran OOM. Decrease the number of concurrent evaluations. Change-Id: I2648ebdedf09b80c9a231c4614004f953a646bc0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12662 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu>
2024-10-19 r/8839 fix(tvix/glue/tvix_store_io): err from store_path_to_node with trace lvlFlorian Klink1-1/+1
When evaluating nixpkgs from the <nixpkgs> channel, store_path_to_node returns an error, falling back to regular filesystem access. This currently produces a warning in the CLI, which is misleading, so degrade to trace level. Change-Id: I4cb2297cc85a2c0e904a37343748f9051aa6d5c7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12665 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: raitobezarius <tvl@lahfa.xyz>
2024-10-19 r/8838 refactor(tvix/store/pathinfo/signing_wrapper): remove cloneFlorian Klink1-9/+17
Construct the owned signature in a separate scope, so all borrows to the original PathInfo are already dropped again, and we can modify the PathInfo without having to clone it. Change-Id: I03e7390540c2cfe7a2c61850bdbe8a33d213a5d9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12663 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: raitobezarius <tvl@lahfa.xyz>
2024-10-19 r/8837 refactor(tvix): make indicatif.pb_show=1 more explicitFlorian Klink3-47/+126
This pushes generating spans with pb_show up to the caller. They usually have more context on how to present things, if at all. Change-Id: Icfcaa64a8a57dce50c0261f2d06e7c051e3946c2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12657 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: raitobezarius <tvl@lahfa.xyz>
2024-10-19 r/8836 refactor(tvix/castore): add try_into_anonymous_node, rename to try_*Florian Klink10-31/+59
We have two places where we parse protos and want their names to be empty: - Receiving a root node in a nar-bridge NAR request - Processing the CalculateNAR gRPC call We don't have any place where we want to keep a name as bytes::Bytes around, yet we used the `into_name_bytes_and_node` method. It was also a bit wrongly named - it wasn't very clear the name was not validated, and that the function may fail. This moves the "splitting off the name as bytes::Bytes" part into a private helper, only leaving the `try_into_name_and_node` and `try_into_anonymous_node` methods around. Change-Id: I2c7fd9871d49ec67450d7efa6a30d96197fb319c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12664 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Marijan Petričević <marijan.petricevic94@gmail.com> Reviewed-by: raitobezarius <tvl@lahfa.xyz>
generated by cgit-pink 1.4.1 (git 2.44.2) at 2024-11-23T08·07+0000