about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2024-10-26 r/8858 fix(users/flokli/slides/2023-nixcon): fix pdf genFlorian Klink1-4/+4
reveal-md didn't exit with a nonzero exit code and just didn't contain the PDF. Fix this. Change-Id: Ie4bc7cbf4b9117b0a672a3294e9e64fb13459247 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12683 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-26 r/8857 fix(users/flokli/nixon-2024): fix pdf genFlorian Klink1-4/+4
Change-Id: I02c101fc16e4ce57d53cd423f7aa0b6a98f856df Reviewed-on: https://cl.tvl.fyi/c/depot/+/12685 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: flokli <flokli@flokli.de>
2024-10-26 r/8856 feat(users/flokli/nixon-2024): initFlorian Klink11-0/+297
Change-Id: I547a5504f6782169dd7280c0b5c21cbe66068a2e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12682 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Autosubmit: flokli <flokli@flokli.de>
2024-10-24 r/8855 refactor(tvix/build): use stricter BuildRequest typeMarijan Petričević12-175/+221
Change-Id: Ifadd190e10ec22570ab3ccb4df54f64ae5ef0a44 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12674 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-23 r/8854 chore(tvix/cli): drop direct nix-compat dependencyFlorian Klink3-6/+0
This is only using nix-compat through tvix-glue. Change-Id: Ib6391987954a28cc05a2c27c1c21585185d82d1a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12681 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI
2024-10-23 r/8853 chore(tvix/cli): drop direct castore dependencyFlorian Klink3-6/+0
This is only using tvix-castore through tvix-store. Change-Id: I342ee1e18f8c3946b712cfb446520b732091d58f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12680 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
2024-10-23 r/8852 chore(3p/sources): bump channels & overlays (2024-10-12)Vincent Ambo3-20/+17
* amend keycloak configuration as per upgrade guide for their latest, most innovative breaking changes. https://www.keycloak.org/docs/latest/upgrading/index.html#deprecated-proxy-option * users/aspen: remove deprecated noXlibs option. This option has no alternative. Change-Id: I49f45e38cda6b01ddf6f014b7b1c43972b76629f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12601 Tested-by: BuildkiteCI Reviewed-by: aspen <root@gws.fyi> Autosubmit: tazjin <tazjin@tvl.su>
2024-10-22 r/8851 fix(tazjin/dotfiles): make trackball left-handedVincent Ambo1-0/+4
... because it's on the left side! Change-Id: I1d67d797bd6137705e69b96349faa32a9c3e94ff Reviewed-on: https://cl.tvl.fyi/c/depot/+/12678 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su>
2024-10-21 r/8850 fix(tvix/glue): don't use builtins.currentSystem in testFlorian Klink1-1/+1
This test will otherwise obviously fail on aarch64-linux, or anything not x86_64-linux, as it'll produce a different Derivation. Change-Id: Iedddcb6aeff05e49fc2e6da27f08111cdc9affec Reviewed-on: https://cl.tvl.fyi/c/depot/+/12677 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI
2024-10-20 r/8849 feat(users/edef/weave): use tracing_indicatif for progressedef6-115/+1072
Progress bars :3 Change-Id: I770d0f8381521b6efc8b38c0db4d59c771887fee Reviewed-on: https://cl.tvl.fyi/c/depot/+/12673 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-19 r/8848 feat(ops/users): add marijan to usersMarijan Petričević1-0/+5
Change-Id: I2d2277915d3e679c9388ea9bc0328b4040b22bf6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12671 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8847 feat(users/edef): add .gitignore fileFlorian Klink1-0/+3
Change-Id: Ia91100f342be2b5ad6ab83bbb3844f2526ea3036 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12672 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu>
2024-10-19 r/8846 feat(users/edef/weave): use FxHashSet and dedupe earlyedef4-4/+33
Deduping early saves a fair bit of memory, but the extra hashing is costly. We switch to FxHash, since we don't need a DoS-proof hash, but we do need it to be *fast*. Change-Id: Ic6b7010874c417862baa9b882593208c8dd1d5e6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12648 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8845 feat(users/edef/weave): ingest roots in Parquet formatedef1-13/+15
Parsing of store-paths.xz is now handled by //users/edef/fetchroots. Change-Id: I78be5aada0c0a321ed79d80c9b615e5f997ac3e0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12670 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-19 r/8844 refactor(users/edef/weave/swizzle): use polars streamingedef5-112/+70
This vastly reduces the memory requirements, so we can run in ~40G RAM. Change-Id: I4952a780df294bd852a8b4682ba2fd59b9bae675 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12667 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8843 refactor(users/edef/weave): simplify OwningRef handlingedef2-32/+12
We switch to working with the underlying Arc<Bytes<u8>> type, since Buffer<u8> is already essentially an OwningRef-esque subslice. Because we're now working with an exposed Arc directly, we don't need to have our own `unsafe impl StableAddress` any more. Change-Id: I9ce2edc6899177145e15b72aa5380f708a62173c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12668 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8842 refactor(users/edef/weave): use swap rather than CASedef1-3/+5
We only care about ordering on the same variable, and we rely on the release barrier provided by rayon's thread joining. The comparison failing is always an error path, and we're indifferent about which thread it fails on. Change-Id: I592a7eaae5b6935cf424c6576a49786f39909fb6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12666 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-19 r/8841 refactor(users/edef/weave): simplify DoubleEndedIterator boundedef1-1/+1
Thanks, Clippy! Change-Id: I116b478124b72e070e94150ee850532752f64d60 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12669 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8840 fix(ops/pipelines): limit depot-nix-eval to concurrency of 3Florian Klink1-1/+1
It seems we need more memory these days, and llama frequently ran OOM. Decrease the number of concurrent evaluations. Change-Id: I2648ebdedf09b80c9a231c4614004f953a646bc0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12662 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu>
2024-10-19 r/8839 fix(tvix/glue/tvix_store_io): err from store_path_to_node with trace lvlFlorian Klink1-1/+1
When evaluating nixpkgs from the <nixpkgs> channel, store_path_to_node returns an error, falling back to regular filesystem access. This currently produces a warning in the CLI, which is misleading, so degrade to trace level. Change-Id: I4cb2297cc85a2c0e904a37343748f9051aa6d5c7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12665 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: raitobezarius <tvl@lahfa.xyz>
2024-10-19 r/8838 refactor(tvix/store/pathinfo/signing_wrapper): remove cloneFlorian Klink1-9/+17
Construct the owned signature in a separate scope, so all borrows to the original PathInfo are already dropped again, and we can modify the PathInfo without having to clone it. Change-Id: I03e7390540c2cfe7a2c61850bdbe8a33d213a5d9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12663 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: raitobezarius <tvl@lahfa.xyz>
2024-10-19 r/8837 refactor(tvix): make indicatif.pb_show=1 more explicitFlorian Klink3-47/+126
This pushes generating spans with pb_show up to the caller. They usually have more context on how to present things, if at all. Change-Id: Icfcaa64a8a57dce50c0261f2d06e7c051e3946c2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12657 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: raitobezarius <tvl@lahfa.xyz>
2024-10-19 r/8836 refactor(tvix/castore): add try_into_anonymous_node, rename to try_*Florian Klink10-31/+59
We have two places where we parse protos and want their names to be empty: - Receiving a root node in a nar-bridge NAR request - Processing the CalculateNAR gRPC call We don't have any place where we want to keep a name as bytes::Bytes around, yet we used the `into_name_bytes_and_node` method. It was also a bit wrongly named - it wasn't very clear the name was not validated, and that the function may fail. This moves the "splitting off the name as bytes::Bytes" part into a private helper, only leaving the `try_into_name_and_node` and `try_into_anonymous_node` methods around. Change-Id: I2c7fd9871d49ec67450d7efa6a30d96197fb319c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12664 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Marijan Petričević <marijan.petricevic94@gmail.com> Reviewed-by: raitobezarius <tvl@lahfa.xyz>
2024-10-18 r/8835 refactor(tvix/[ca]store): use auto_implFlorian Klink16-99/+85
This implements BS, DS, PS for Box'ed or Arc'ed variants of it with less code, and less potential to accidentially forget to proxy default trait methods for blanked impls, as fixed in cl/12658. Change-Id: If2cdbb563a73792038ebe7bff45d6f880214855b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12661 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu>
2024-10-18 r/8834 docs(tvix/TODO): add instance_name idea for storesFlorian Klink1-0/+4
Change-Id: If14f81ca7180109195f35352b0f43b8d997176cd Reviewed-on: https://cl.tvl.fyi/c/depot/+/12660 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI
2024-10-18 r/8833 fix(tvix/store/pathinfo): use gRPC NarCalculationServiceFlorian Klink2-1/+14
If the PathInfoService is using gRPC, expose it via the nar_calculation_service() method in the PathInfoService. Also pass nar_calculation_service through in tha blanket impl. This now causes a `tvix-store import` using the default config to not fall back to `SimpleRenderer`, which will calculate the NAR hash and size by downloading the uploaded blobs (and blobs it didn't need to upload) locally, making such imports faster. Change-Id: If2c3fe6584e9093cba322d2360f355a3923904ae Reviewed-on: https://cl.tvl.fyi/c/depot/+/12658 Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu> Autosubmit: flokli <flokli@flokli.de>
2024-10-18 r/8832 fix(tvix/store/grpc_wrapper): don't validate node nameFlorian Klink1-4/+7
Clients can (and do) send an empty name in here, and we discard it anyways. Change-Id: Iec135d9cba48cc066464e5639319c845079787e9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12659 Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de>
2024-10-18 r/8831 refactor(tvix/build): remove proto::BuildRequest::validateMarijan Petričević3-115/+12
Change-Id: I96fa98946bf6aff5eedcb220e2b6b3d90c204eec Reviewed-on: https://cl.tvl.fyi/c/depot/+/12633 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-18 r/8830 refactor(tvix/build): add stricter BuildRequest typeMarijan Petričević3-3/+315
Change-Id: I2950c76bbc2227952e583426bfb3ed34e8da6d2d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12625 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-17 r/8829 chore(users/edef/crunch-v2): bump crate dependenciesFlorian Klink2-25/+25
Fixes rustls 0.20.9: RUSTSEC-2024-0336 (CVE-2024-32650, GHSA-6g7w-8wpp-frhj) Change-Id: I1be307876465f47c28af05c4b515bf6a7b6713ef Reviewed-on: https://cl.tvl.fyi/c/depot/+/12654 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI
2024-10-17 r/8828 fix(users/edef/weave): use safer_owning_refedef4-33/+35
owning_ref has serious unsoundness. Change-Id: Ie760697cd6399e6bc75f1ad17c9bb74adc077a35 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12656 Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI Autosubmit: edef <edef@edef.eu> Reviewed-by: flokli <flokli@flokli.de>
2024-10-17 r/8827 chore(users/edef/turbofetch): bump crate dependenciesFlorian Klink2-20/+20
Fixes rustls 0.20.9: RUSTSEC-2024-0336 (CVE-2024-32650, GHSA-6g7w-8wpp-frhj) Change-Id: Id38f867a85320e3a3ca870dbf224c4fd4c5abacb Reviewed-on: https://cl.tvl.fyi/c/depot/+/12655 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu>
2024-10-17 r/8826 docs(tvix/TODO): extend NAR rendering prefetching ideaFlorian Klink1-2/+7
With the seekable NAR renderer, figuring out the next few blobs to render became possible. Change-Id: I1214302f88e6f9aba74227f84df0f964d587baf2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12652 Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu> Autosubmit: flokli <flokli@flokli.de>
2024-10-17 r/8825 refactor(tvix/store): remove use of lazy_staticFlorian Klink9-123/+119
This is now supported in the standard library via std::sync::LazyLock, but requires some manual shuffling around of code. Change-Id: Ifca792f4d2dbc36b703de4a4dfa406015ab86da7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12614 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI
2024-10-17 r/8824 refactor(tvix/castore): remove remaining lazy_static usageFlorian Klink4-16/+8
Change-Id: I86480cf625a457c4aa8153262f829d34c230b084 Co-authored-by: edef <edef@edef.eu> Reviewed-on: https://cl.tvl.fyi/c/depot/+/12613 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu>
2024-10-17 r/8823 refactor(tvix/castore): remove use of lazy_staticFlorian Klink5-126/+145
This is now supported in the standard library via std::sync::LazyLock, but requires some manual shuffling around of code. Change-Id: Ia0370ca46cb1c6122a452b1d117160536b632c7e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12612 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2024-10-17 r/8822 refactor(nix-compat/store_path): drop build_nar_based_store_pathFlorian Klink2-17/+5
This is the only (remaining) occurence of it, and not really more code than just calling store_path::build_ca_path with `CAHash::Nar(NixHash::Sha256(…))`, especially considering we need the CAHash in the PathInfo struct later anyways - so let's remove this function. Change-Id: Ia82212086062c366e0280ca0823d9e68a3f91d3a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12632 Reviewed-by: edef <edef@edef.eu> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-17 r/8821 chore(tvix/castore): remove commented-out test fixtureFlorian Klink1-9/+1
This became obsolete, since the introduction of a stricter `Directory` struct invalid names cannot be represented anymore. Change-Id: I9e4b1b6cca01831d0a9735f58d8a1f59ac18676b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12615 Reviewed-by: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-17 r/8820 docs(tvix/TODO): drop PathInfo including references by content ideaFlorian Klink1-27/+0
This is not gonna work out as-is, as we still key PathInfos by their store path digest, and how to handle thing if we encounter a Frankenbuild. For now, let's keep the PathInfoService data as it is, we can record this information (and more) in the builder structures. Change-Id: Ic38fc3ecd8096a5fe002e681bdc812a9dbeaa7d2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12607 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu>
2024-10-17 r/8819 fix(minecraft-fabric): avoid unset CREDENTIALS_DIRECTORY in ExecStopsterni1-3/+8
For mystifying reasons, Type=simple and CREDENTIALS_DIRECTORY in ExecStop have stopped working (when exactly I don't know, but presumably 256). Apparently, you are supposed to use Type=exec with credentials due to raciness (I've personally never experienced): <https://github.com/systemd/systemd/issues/32583>. Just changing the type did not resolve the issue of CREDENTIALS_DIRECTORY being unset, though. It appears, though, that the issue is merely an unset environment variable and not the credentials being unavailable: We can work around the problem by setting an appropriate environment variable ourselves. Change-Id: Ifcdb1f3bce782ea1c568a9bc413f3fb29f0985c5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12649 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2024-10-17 r/8818 docs(users/edef/fetchroots): add a README for other userszimbatm1-0/+36
Change-Id: Ibce9121fbd209e713ce04271e285f70e2af9867e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12646 Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu> Reviewed-by: flokli <flokli@flokli.de>
2024-10-17 r/8817 chore(users/edef/fetchroots): wire up the buildzimbatm4-4/+12634
Change-Id: I6830b885394001882b54fddf310bbd38d253679a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12645 Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-17 r/8816 feat(users/edef/fetchroots): initedef3-0/+3620
Change-Id: I6861661bcd99652a1875ccde421e78e87c45054c Reviewed-on: https://cl.tvl.fyi/c/depot/+/11094 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu>
2024-10-16 r/8815 refactor(tvix/glue): merge builtins.{filterSource,path} codepathsFlorian Klink1-108/+82
This moves the implementation from builtins.path into a helper function, which we now call from both builtins. Most of the Value plumbing stays inside this helper. We also implemented handling of symlinks at the root, which was handled in builtins.filterSource, but not builtins.path - by peeking at the FileType using std::fs::metadata, instead of the EvalIO trait. For now, this is fine, as our filtered_ingest also goes via the filesystem directly. It ends up with the same semantics as before and in Nix - symlinks at the root are followed, except if they point to an invalid target. In the future, we should revisit this, and then maybe get both stat and lstat into EvalIO, though we will need to be very careful about the semantics for following symlink inside store paths. Change-Id: I6a941c0187db36165c2f7a338015e4e32d41b298 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12629 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
2024-10-16 r/8814 fix(tvix/glue/builtins/import): Drop useless bstring conversionIlan Joselevich1-4/+1
In a previous refactoring CL this into_bstring method was accidentally kept, when we don't need it and can just to_str directly. Change-Id: Idd531d508b8fd530611b213d0164e7aaf0e87d80 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12631 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Autosubmit: Ilan Joselevich <personal@ilanjoselevich.com>
2024-10-16 r/8813 feat(tvix/eval/io): impl From<std::fs::FileType> for FileTypeFlorian Klink1-0/+14
Change-Id: If92ddaf3b469c4635c234b193f8d7716e11887f6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12630 Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Autosubmit: flokli <flokli@flokli.de>
2024-10-16 r/8812 refactor(tvix/eval/builtin-macros): use match block for f.blockedef1-20/+34
These nested ifs are a bit confusing, a match block makes this cleaner. Change-Id: I256fd0bc921fbf2e60ad0f6e1ea51c2e0fb00317 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12628 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-15 r/8811 refactor(tvix/glue/builtins/import): refactorFlorian Klink6-231/+204
This removes all the intermediate helper functions and reorganizes the import code to only do the calculations where/when needed, and hopefully makes things easier to understand as well. Change-Id: I7e4c89c742bf8569b45e303523f7f801da7127ea Reviewed-on: https://cl.tvl.fyi/c/depot/+/12627 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Jörg Thalheim <joerg@thalheim.io> Reviewed-by: edef <edef@edef.eu>
2024-10-15 r/8810 test(tvix/glue): improve comments and test cases a bitFlorian Klink1-14/+12
This makes it easier to understand what the specific test is testing. Change-Id: I34b2798841c6b9367849668451af2165dc78f997 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12626 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI Reviewed-by: Jörg Thalheim <joerg@thalheim.io>
2024-10-15 r/8809 test(tvix/glue): add builtins.storeDir regression testFlorian Klink3-0/+9
Change-Id: Ib87f41b3e0d634dd76e648acfe1b3026211f947a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12619 Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Jörg Thalheim <joerg@thalheim.io> Tested-by: BuildkiteCI