about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2024-08-27 r/8594 chore(users/azahi): add OWNERS fileazahi1-0/+3
Change-Id: Ic192e12b8858cc321a91c9ff545bdaaee75503c5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12354 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-08-27 r/8593 fix(tvix/store): restore v1alpha reflection endpointFlorian Klink7-17/+31
tonic-reflection 0.12.x moved from the v1alpha to v1 of the reflection protocol. However, most clients, like Postman, Kreya and evans don't support that one yet. Bump tonic-reflection to 0.12.2, which re-introduces v1alpha support alongside the v1 version of it, registering both services. This fixes the example documented in tvix/store/README.md, it was previously failing as evans couldn't find the v1alpha reflection service. See https://github.com/hyperium/tonic/pull/1888 for details. Change-Id: I55438877317f82dc39face13afeb9594cda07a4e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12353 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
2024-08-27 r/8592 feat(tazjin/cursed): add bubblegum demo from VolgaSprint talkVincent Ambo2-0/+85
Change-Id: I4d9bd21e3dd6dbc24d46907e6270d49b97f50b99 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12352 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2024-08-27 r/8591 fix(web/bubblegum): third_party/sources is required in bubblegumVincent Ambo1-0/+1
Change-Id: Ifb63ab95a0a11f07e8ad2346aff5893fe7c268cd Reviewed-on: https://cl.tvl.fyi/c/depot/+/12351 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2024-08-26 r/8590 feat(ops/users): add yl3dyVincent Ambo1-0/+5
Change-Id: I05a11bb1f3496680c22b31a4450e4675d028c59d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12350 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su>
2024-08-25 r/8589 chore(users/aspen): use cargo-* packages from nixpkgsFlorian Klink3-58/+4
These started throwing eval warnings due to usage of cargoSha256, and are both available in nixpkgs. Change-Id: Ice636bebc0a839410125bc19b2252158add2b96e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12337 Tested-by: BuildkiteCI Reviewed-by: aspen <root@gws.fyi> Autosubmit: flokli <flokli@flokli.de>
2024-08-25 r/8588 chore(users/aspen): hardware.opengl -> hardware.graphicsFlorian Klink2-2/+2
Change-Id: I388a26221b805bc2aa7563d464888cc8b9ea9c92 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12336 Tested-by: BuildkiteCI Reviewed-by: aspen <root@gws.fyi> Autosubmit: flokli <flokli@flokli.de>
2024-08-25 r/8587 fix(tvix/nix-compat): Feature flag code only used in asyncBrian Olsen1-2/+7
When only the wire feature was enabled two methods were unused and so would faild `cargo check --no-default-features --features wire`. This feature flags those two methods on async feature since that is the only place they are used. Change-Id: I6ec18a670e3c6e3ecee8d1417c99f1a5084e0ae7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12346 Reviewed-by: flokli <flokli@flokli.de> Autosubmit: Brian Olsen <me@griff.name> Tested-by: BuildkiteCI
2024-08-25 r/8586 feat(tvix/nix-compat-derive): Add deriver for NixDeserializeBrian Olsen48-3/+2376
This adds a nix-compat-derive derive crate that implements a deriver for NixDeserialize implementations. This is to reduce the amount of code needed to implement deserialization for all the types used by the Nix daemon protocol. Change-Id: I484724b550e8a1d5e9adad9555d9dc1374ae95c2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12022 Autosubmit: Brian Olsen <me@griff.name> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-08-25 r/8585 feat(nix-compat): Add NixDeserialize and NixRead traitsBrian Olsen22-166/+1499
Add a trait for deserializing a type from a daemon worker connection. This adds the NixDeserialize trait which is kind of like the serde Deserialize trait in that individual types are meant to implement it and it can potentially be derived in the future. The NixDeserialize trait takes something that implements NixRead as input so that you can among other things mock the reader. Change-Id: Ibb59e3562dfc822652f7d18039f00a1c0d422997 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11990 Autosubmit: Brian Olsen <me@griff.name> Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-08-25 r/8584 feat(ops/users): Add azahi to usersAzat Bahawi1-0/+5
Change-Id: I4df81b7f08e173d3c887bc89f869889a7901dbf0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12347 Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-08-25 r/8583 feat(volgasprint-cache): enable auto deployVincent Ambo1-1/+6
Change-Id: I3b0a4695f69ef24a4f1f6280402c8a72223ff0c9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12344 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: mrflos <mrflos@yeswiki.pro>
2024-08-25 r/8582 chore(ops/machines): add nixery & cache machines to system listVincent Ambo1-0/+2
Change-Id: I40a4e7b9b993b2af57b03da1036ddeca2a0d298a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12343 Reviewed-by: mrflos <mrflos@yeswiki.pro> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su>
2024-08-25 r/8581 feat(tazjin/german-string): impl Clone for GermanStringVincent Ambo1-0/+20
Small strings are always copied fully, without allocations. Large transient strings copy the data and allocate. Large persistent strings are also a trivial copy. Change-Id: I319c0b800fa7a4a62e634176b959bb2fa766a4eb Reviewed-on: https://cl.tvl.fyi/c/depot/+/12342 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2024-08-25 r/8580 feat(ops/machines): add temporary VolgaSprint cache machineVincent Ambo2-0/+149
Change-Id: I5b5bb98f591e7bf3b1f16673f7f670b758444066 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12327 Reviewed-by: mrflos <mrflos@yeswiki.pro> Tested-by: BuildkiteCI
2024-08-25 r/8579 chore(users/tazjin): hardware.opengl -> hardware.graphicsFlorian Klink5-7/+7
Change-Id: I649a6de6eef0b9b8c9cb658fdb6e4e46f5c8be1c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12335 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-08-24 r/8578 chore(tvix/tools/turbofetch): bump depsFlorian Klink2-34/+53
h2: - https://rustsec.org/advisories/RUSTSEC-2024-0332.html - https://rustsec.org/advisories/RUSTSEC-2024-0003.html mio: - https://rustsec.org/advisories/RUSTSEC-2024-0019.html shlex: - https://rustsec.org/advisories/RUSTSEC-2024-0006.html zerocopy: - https://rustsec.org/advisories/RUSTSEC-2024-0006.html Change-Id: I7ce3cab410b9c2b6c28474ca81c3fa5b5283f3fd Reviewed-on: https://cl.tvl.fyi/c/depot/+/12341 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Connor Brewster <cbrewster@hey.com>
2024-08-24 r/8577 chore(tvix/tools/crunch-v2): bump depsFlorian Klink2-20/+24
h2: - https://rustsec.org/advisories/RUSTSEC-2024-0332.html - https://rustsec.org/advisories/RUSTSEC-2024-0003.html mio: - https://rustsec.org/advisories/RUSTSEC-2024-0019.html shlex: - https://rustsec.org/advisories/RUSTSEC-2024-0006.html zerocopy: - https://rustsec.org/advisories/RUSTSEC-2024-0006.html Change-Id: Ia5f6f96378d5f7e77e178dc054f47bda8b766a30 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12340 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Connor Brewster <cbrewster@hey.com>
2024-08-24 r/8576 chore(tvix/tools/weave): bump mioFlorian Klink2-4/+4
https: //rustsec.org/advisories/RUSTSEC-2024-0019.html Change-Id: I03543105b35da6407a4930893b1514b379a89fbc Reviewed-on: https://cl.tvl.fyi/c/depot/+/12339 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Connor Brewster <cbrewster@hey.com>
2024-08-24 r/8575 chore(depotfmt): exclude users/emery/*Vincent Ambo1-0/+1
Change-Id: I971456e97a809665fdd011c31b0437510f4b7fba Reviewed-on: https://cl.tvl.fyi/c/depot/+/12306 Reviewed-by: emery <emery@dmz.rs> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su>
2024-08-24 r/8574 fix(cgit-tvl): disable follow-links in cgitVincent Ambo1-1/+1
These cause segfaults in cgit due to an old wontfix git issue: https://bugzilla.redhat.com/show_bug.cgi?id=1791810 Change-Id: I831655faf3cfdef5bad13eba8cb8bb274de83ea0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12307 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-08-23 r/8573 fix(ops/modules): re-add cheddar highlighting serverVincent Ambo2-0/+33
This was deleted when removing the Sourcegraph module, but it turns out it is also needed by panettone. Change-Id: I8f14165bf783743247894c2b64882fbb032ffbf8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12295 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-08-23 r/8572 feat(users/picnoir/tvix-daemon): Add crate2nix-checkIlan Joselevich1-0/+10
Change-Id: I92a2fd6369e1f45c8afa25f778ac424782699b55 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12304 Reviewed-by: flokli <flokli@flokli.de> Autosubmit: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI
2024-08-23 r/8571 feat(tvix/tools/weave): Add crate2nix-checkIlan Joselevich1-1/+3
Change-Id: I4e02f56678e6efa6e2656b2f7398b6ad92581c57 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12303 Autosubmit: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-08-23 r/8570 feat(tvix/tools/turbofetch): Add crate2nix-checkIlan Joselevich1-1/+3
Change-Id: Ie615d824032c85af6f8f40419bc22d7e3f38bb4c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12302 Tested-by: BuildkiteCI Autosubmit: Ilan Joselevich <personal@ilanjoselevich.com> Reviewed-by: flokli <flokli@flokli.de>
2024-08-23 r/8569 feat(tvix/tools/narinfo2parquet): Add crate2nix-checkIlan Joselevich1-1/+3
Change-Id: I22bc6e7711e5e2c0a76d4eea4dd6edaf724e4cef Reviewed-on: https://cl.tvl.fyi/c/depot/+/12301 Autosubmit: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-08-23 r/8568 feat(tvix/tools/crunch-v2): Add crate2nix-checkIlan Joselevich1-1/+3
Change-Id: I922caae2ec3f87a7f3a5dcc8e9d366f0e71ce900 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12300 Tested-by: BuildkiteCI Autosubmit: Ilan Joselevich <personal@ilanjoselevich.com> Reviewed-by: flokli <flokli@flokli.de>
2024-08-23 r/8567 feat(users/emery/pkgs): add syndicate-serverEmery Hemingway1-0/+34
Change-Id: I3cd358e55a7f0208af8fe8aa990b9f2ee7ffe865 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12299 Reviewed-by: emery <emery@dmz.rs> Tested-by: BuildkiteCI
2024-08-23 r/8566 feat(web/tvixbolt): Add crate2nix-check and re-generate Cargo.nixIlan Joselevich2-0/+87
Change-Id: Ib9881efd6a78ba28e283759e0ed5125fb175b89e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12221 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-08-23 r/8565 feat(tvix/utils): Add mkCrate2nixCheckIlan Joselevich2-56/+36
This adds a function which can be used across the monorepo to create a an extra CI step that checks whether the Cargo.nix file is up-to-date. Change-Id: Idb8298b29ddc2ca5dff1facb1b9ed86a236ee66d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12227 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-08-23 r/8564 feat(ops/users): add mrflosVincent Ambo1-0/+5
Patch submitted via public inbox. Change-Id: I5dc2d86aefd909216e8a16f428fc2cf818a125c2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12296 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-08-23 r/8563 chore(tools/depotfmt): remove terraform fmtVincent Ambo1-10/+0
This adds almost a gigabyte of closure size for formatting files that almost never change. I'll look into building just the formatter somehow, but it's not a very high priority task. Change-Id: Ib0f841e1a98133381c5ae154e2a57df8af52dc1f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12293 Tested-by: BuildkiteCI Reviewed-by: emery <emery@dmz.rs> Autosubmit: tazjin <tazjin@tvl.su>
2024-08-23 r/8562 feat(users/emery): add custom Cyrillic keyboard layoutEmery Hemingway2-0/+121
Change-Id: I37f95c904e8a05cf8d8e437c41b9710c2ebf0300 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12294 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-08-23 r/8561 feat(tvix/nar-bridge): send content-type headersFlorian Klink3-9/+18
This prevents browsers from treating NARInfo and nix-cache-info paths as a separate "Download", but just show it in plaintext. Change-Id: If99abe20ef1d24e4fa86c055160861ca47aa81ce Reviewed-on: https://cl.tvl.fyi/c/depot/+/12267 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Connor Brewster <cbrewster@hey.com>
2024-08-23 r/8560 feat(nix-compat): add constants for mime typesFlorian Klink1-0/+7
This adds the MIME types Nix uses when uploading files to a S3 bucket / HTTP endpoint. It ignores them when retrieving. Change-Id: I75fa96d5e53349f0470bbe8cbba93f961fbd5f05 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12266 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Connor Brewster <cbrewster@hey.com> Tested-by: BuildkiteCI
2024-08-23 r/8559 feat(ops/users): add nikivVincent Ambo1-0/+5
Patch submitted to me IRL. Change-Id: Idd8aa75313ba73d5c1e92b98d390e43e7108c6b6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12292 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su>
2024-08-23 r/8558 docs: remove mention of Sourcegraph from depot READMEVincent Ambo1-4/+3
Change-Id: I721d08d2862256e5e973792b8fc7fac73b0326fc Reviewed-on: https://cl.tvl.fyi/c/depot/+/12288 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-08-23 r/8557 chore(ops/besadii): remove sourcegraph index update supportVincent Ambo2-38/+1
Change-Id: I4ee9a5a69c90e2050c60b2ef8483431d691b499f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12287 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-08-23 r/8556 chore(whitby): remove Sourcegraph instanceVincent Ambo2-64/+0
Change-Id: I4d03f98e79de5e3a9c8c4a33682d5c78e3e0f028 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12286 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-08-23 r/8555 feat(ops/users): add azizVincent Ambo1-0/+5
Patch submitted to me IRL. Change-Id: I43805e3932ccbe383fb5ec7780a29fae187f64db Reviewed-on: https://cl.tvl.fyi/c/depot/+/12290 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-08-23 r/8554 feat(ops/users): add emeryVincent Ambo1-0/+5
Patch submitted to me IRL. Change-Id: I4cbfb138f616adf8635ca84f25cb77f8b8af7959 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12289 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2024-08-23 r/8553 feat(ops/www): redirect cs.tvl.fyi to livegrep & cgitVincent Ambo1-7/+42
Goodbye, Sourcegraph. Relates to b/290. Change-Id: Ic1cf3c1cf52ae17cdcc18c675b4c01d477644a3c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12285 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-08-23 r/8552 chore(web/atward): remove sourcegraph supportVincent Ambo3-173/+5
We're moving away from sourcegraph to livegrep and so on, as Sourcegraph has gone fully proprietary. This removes support for redirecting to Sourcegraph. Relates to b/290 Change-Id: I04ccf8dfef72113cd49d444151cb0c3eb834845d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12268 Reviewed-by: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2024-08-22 r/8551 feat(tazjin/german-string): add constructor that leaks a Vec<u8>Vincent Ambo1-2/+29
Change-Id: Id0b6b4794128573ddb62e82fd77d080e564978be Reviewed-on: https://cl.tvl.fyi/c/depot/+/12264 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su>
2024-08-22 r/8550 feat(tazjin/german-string): add persistent construction from staticsVincent Ambo1-9/+56
Makes it possible to construct persistent German Strings from data with 'static lifetime. This doesn't leak any additional data. Change-Id: Ifb3a36ff72b106724883302e4c2195ac54acd352 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12263 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su>
2024-08-22 r/8549 refactor(tazjin/german-string): add type for encoding storage classVincent Ambo1-6/+24
Adds a StorageClassPtr type that is set up to be able to steal bits from an aligned pointer to encode the storage class of a German String. Change-Id: I64591174eac1ebcb73e624a59bd107ba1e02c69d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12262 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-08-21 r/8548 fix(tvix/castore): u32 -> u64 in DirectoryError::SizeOverflow messageBen Webb1-1/+1
Fix a discrepancy in the error message for DirectoryError::SizeOverflow. The message indicates that the SizeOverflow error occurs when total size exceeds u32::MAX, but that's not true. All size fields within the castore's internal Directory ADT are u64, and the SizeOverflow error is only returned after a call to the checked_add implementation on u64. See tvix/castore/nodes/directory.rs +111 and tvix/castore/nodes/directory.rs +88 as of this commit. Change-Id: I74d161ea8927362e1cb601ba163489aa96fb91b1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12259 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-08-21 r/8547 feat(nix-compat/nix_http): init parse_nar[info]_strFlorian Klink15-178/+634
This moves the URL component parsing code we had in nar-bridge to nix-compat. We change the function signature to return an Option, not a Result<_, StatusCode>. This allows returning more appropriate error codes, as we can ok_or(…) at the callsite, which we now do: on an upload to an invalid path, we now return "unauthorized", while on a GET/HEAD, we return "not found". This also adds support to parse compression suffixes. While not supported in nar-bridge, other users of nix-compat might very well want to parse these paths. Also fix the error message when parsing NAR urls, it mentioned 32, not 52, which is a copypasta error from the narinfo URL parsing code. Change-Id: Id1be9a8044814b54ce68b125c52dfe933c9c4f74 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12260 Reviewed-by: raitobezarius <tvl@lahfa.xyz> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-08-20 r/8546 feat(kontemplate): defaults can now have nested valuesArmin Schlegel2-1/+23
See https://b.tvl.fyi/issues/409 for details. Change-Id: Ibb54fab7a78e0e5f708c2a7dc8bb26ac0b2b4689 Signed-off-by: Armin Schlegel <a.schlegel@gridx.de> Reviewed-on: https://cl.tvl.fyi/c/depot/+/11972 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2024-08-20 r/8545 refactor(nix-compat/store_path): make StorePath generic on SFlorian Klink15-294/+280
Similar to how cl/12253 already did this for `Signature`, we apply the same logic to `StorePath`. `StorePathRef<'a>'` is now a `StorePath<&'a str>`, and there's less redundant code for the two different implementation. `.as_ref()` returns a `StorePathRef<'_>`, `.to_owned()` gives a `StorePath<String>` (for now). I briefly thought about only publicly exporting `StorePath<String>` as `StorePath`, but the diff is not too large and this will make it easier to gradually introduce more flexibility in which store paths to accept. Also, remove some silliness in `StorePath::from_absolute_path_full`, which now doesn't allocate anymore. Change-Id: Ife8843857a1a0a3a99177ca997649fd45b8198e6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12258 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Connor Brewster <cbrewster@hey.com>
generated by cgit-pink 1.4.1 (git 2.44.2) at 2024-11-23T21·14+0000