diff options
| author | Florian Klink <flokli@flokli.de> | 2023-02-03T11·38+0100 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2023-03-11T14·26+0000 |
| commit | c9c8b103701411eddcc00955d30eaa667091963f (patch) | |
| tree | dbbea77caa282c46627d37b1d964aff6fc7f409c /tvix/eval/src/tests/tvix_tests/eval-okay-eq-nested-list.exp | |
| parent | e4687765d79bc07c1252743fe655f0c054ef9ead (diff) | |
feat(tvix/eval): don't warn twice about dead code r/5954
We currently send two warnings in case of detecting dead code - W008
inside compile_dead_code, and a more detailed warning in all places that
invoke compile_dead_code:
```
warning[W007]: useless operation on boolean: this expression is always false
--> /nix/store/qz3gjn95gazab4fkb7s8lm6hz17rdzzy-414z9nnj1wy66ymq6vgb693x9xjz6hf2-nixpkgs-src/pkgs/top-level/perl-packages.nix:12079:15
|
12079 | doCheck = false && !stdenv.isDarwin;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
warning[W008]: this code will never be executed
--> /nix/store/qz3gjn95gazab4fkb7s8lm6hz17rdzzy-414z9nnj1wy66ymq6vgb693x9xjz6hf2-nixpkgs-src/pkgs/top-level/perl-packages.nix:12079:24
|
12079 | doCheck = false && !stdenv.isDarwin;
| ^^^^^^^^^^^^^^^^
```
The place invoking `compile_dead_code` has more context to why the code
is unused, so it's error message is much more useful.
Stop emitting the less informative warning inside compile_dead_code
(W008), and update the comment that we expect the caller to emit a
warning.
I kept W008 itself still around, in case we end up having places this
will get used again.
Change-Id: I2c5d84fc0cb4035872cd4b71cc3e9e34e120eb37
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8024
Tested-by: BuildkiteCI
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Diffstat (limited to 'tvix/eval/src/tests/tvix_tests/eval-okay-eq-nested-list.exp')
0 files changed, 0 insertions, 0 deletions