diff options
author | Vincent Ambo <tazjin@google.com> | 2020-05-20T03·33+0100 |
---|---|---|
committer | Vincent Ambo <tazjin@google.com> | 2020-05-20T03·33+0100 |
commit | d331d3a0b5c497a46e2636f308234be66566c04c (patch) | |
tree | 92526b2f99456c09c5cc81233ed5a4311abe3d2b /third_party/nix/src/nix/run.cc | |
parent | fed31b2c9b364fc1ed0b724c21b068cdedf46ee7 (diff) |
refactor(3p/nix): Apply clang-tidy's modernize-* fixes r/787
This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position).
Diffstat (limited to 'third_party/nix/src/nix/run.cc')
-rw-r--r-- | third_party/nix/src/nix/run.cc | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/third_party/nix/src/nix/run.cc b/third_party/nix/src/nix/run.cc index 523aa87472d6..5459c38952d4 100644 --- a/third_party/nix/src/nix/run.cc +++ b/third_party/nix/src/nix/run.cc @@ -225,7 +225,7 @@ void chrootHelper(int argc, char** argv) { createDirs(tmpDir + storeDir); if (mount(realStoreDir.c_str(), (tmpDir + storeDir).c_str(), "", MS_BIND, - 0) == -1) { + nullptr) == -1) { throw SysError("mounting '%s' on '%s'", realStoreDir, storeDir); } @@ -242,12 +242,13 @@ void chrootHelper(int argc, char** argv) { if (mkdir(dst.c_str(), 0700) == -1) { throw SysError("creating directory '%s'", dst); } - if (mount(src.c_str(), dst.c_str(), "", MS_BIND | MS_REC, 0) == -1) { + if (mount(src.c_str(), dst.c_str(), "", MS_BIND | MS_REC, nullptr) == + -1) { throw SysError("mounting '%s' on '%s'", src, dst); } } - char* cwd = getcwd(0, 0); + char* cwd = getcwd(nullptr, 0); if (!cwd) { throw SysError("getting current directory"); } @@ -260,8 +261,8 @@ void chrootHelper(int argc, char** argv) { if (chdir(cwd) == -1) { throw SysError(format("chdir to '%s' in chroot") % cwd); } - } else if (mount(realStoreDir.c_str(), storeDir.c_str(), "", MS_BIND, 0) == - -1) { + } else if (mount(realStoreDir.c_str(), storeDir.c_str(), "", MS_BIND, + nullptr) == -1) { throw SysError("mounting '%s' on '%s'", realStoreDir, storeDir); } |