about summary refs log tree commit diff
path: root/third_party/nix/.gitignore
diff options
context:
space:
mode:
authorMatthew Tromp <matthewktromp@gmail.com>2024-07-27T19·48-0400
committerclbot <clbot@tvl.fyi>2024-07-27T21·29+0000
commit0b987a509f189bb0b984c1b306a1b05e928b2296 (patch)
tree6c6eaa2598bdead7de97bf951116af6783e3c93f /third_party/nix/.gitignore
parent4769d047b29f3fbad4767a858f4c0f202f2b33a9 (diff)
fix(tvix/eval): don't bubble up io errors from path_exists r/8416
path_exists was returning an error when certain common IO errors were
encountered. e.g. in the path "/dev/null/.", path_exists would throw
an error because the underlying call to Path::try_exists threw an
error because null isn't a directory. But if null isn't a directory,
then the path is invalid, so this should really be returning
false. That's what nix's behavior is and that's what makes sense.

The trait function isn't being changed because some other
implementers (e.g. tvix_store_io) have actual errors they can throw.

Fixes: b/411
Change-Id: I9e810e7a198bffe61365697c6d3d7e71f264c20b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12042
Tested-by: BuildkiteCI
Autosubmit: chickadee <matthewktromp@gmail.com>
Reviewed-by: aspen <root@gws.fyi>
Diffstat (limited to 'third_party/nix/.gitignore')
0 files changed, 0 insertions, 0 deletions