diff options
author | Adam Joseph <adam@westernsemico.com> | 2022-10-25T09·23-0700 |
---|---|---|
committer | tazjin <tazjin@tvl.su> | 2023-01-21T10·19+0000 |
commit | 22b9e6ff092c531ee72037ff8f4c065eaff3b839 (patch) | |
tree | ca3f063bc088e06772626d02d9b0f865edca5bd6 /third_party/immer/tools | |
parent | ab8486e5b8b12f18954d3754c1837882e30008dc (diff) |
refactor(tvix/eval): administer antidote for poison r/5721
The codebase contains a lot of complexity and odd roundabout handling for shadowing globals. I'm pretty sure none of this is necessary, and all of it disappears if you simply make the globals part of the ordinary identifier resolution chain, with their own scope up above the root scope. Then the ordinary shadowing routines do the right thing, and no special cases or new terminology are required. This commit does that. Note by tazjin: This commit was originally abandoned when Adam decided not to take away reviewer bandwidth for this at the time (eval was still in a much earlier stage). As we've recently done some significant refactoring of globals initialisation this came up again, and it seems we can easily cover the use-cases of the poison tracking in other ways now, so I've rebased, updated and resurrected the CL. Co-Authored-By: Vincent Ambo <tazjin@tvl.su> Signed-off-by: Adam Joseph <adam@westernsemico.com> Change-Id: Ib3309a47a7b31fa5bf10466bade0d876b76ae462 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7089 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
Diffstat (limited to 'third_party/immer/tools')
0 files changed, 0 insertions, 0 deletions