about summary refs log tree commit diff
path: root/third_party/glog/ChangeLog
diff options
context:
space:
mode:
authorGriffin Smith <grfn@gws.fyi>2020-08-03T23·45-0400
committerglittershark <grfn@gws.fyi>2020-08-04T00·43+0000
commit26a59482d2427f640893517f1b24dd650a5bd5da (patch)
tree79698ee863dd395a2e4099904d38a92030ea62f1 /third_party/glog/ChangeLog
parent2344f8e5289ccd64f2eb3594aac3fee62f76395a (diff)
fix(3p/nix): pass SkipEmpty to StrSplit("", ...) r/1574
When tokenizeString was changed to absl::StrSplit, there was a behavior
change because tokenizeString on an empty string returned an empty
vector - which the derivation builder (and likely a bunch of other
stuff) was depending on. The canonical way of fixing this is by passing
absl::SkipEmpty() to the function - there may be other places we need to
fix this as well.

This commit also includes some opportunistic absl::StrFormats and
StrCats, because I was here anyway, but those have no semantic
difference.

Change-Id: Ibf9bb602284f793fa55728481f63b838fb7a41db
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1631
Reviewed-by: tazjin <mail@tazj.in>
Tested-by: BuildkiteCI
Diffstat (limited to 'third_party/glog/ChangeLog')
0 files changed, 0 insertions, 0 deletions