From 0128323c555b6209315f30a723af3a62f63d446e Mon Sep 17 00:00:00 2001 From: sterni Date: Wed, 14 Jun 2023 12:47:15 +0200 Subject: docs(tvix): mention langVersion >= 5 check in nixpkgs Change-Id: I7aae900012e901fa4d886b1a4bf0657d593e4983 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8771 Autosubmit: sterni Reviewed-by: tazjin Tested-by: BuildkiteCI --- tvix/docs/lang-version.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tvix/docs/lang-version.md b/tvix/docs/lang-version.md index c09422a589..c288274c91 100644 --- a/tvix/docs/lang-version.md +++ b/tvix/docs/lang-version.md @@ -44,8 +44,9 @@ Eelco Dolstra writes as to what changed: > change as a build.cc (i.e. daemon) change, but we don't really have a way to > express that... -Probably `builtins.nixVersion` (which was added in version 1) should have been -used instead. +Maybe `builtins.nixVersion` (which was added in version 1) should have been +used instead. In any case, the [only `langVersion` check][nixpkgs-langVersion-5] +in nixpkgs verifies a lower bound of 5. ## 6 @@ -58,3 +59,4 @@ Nix version 6 added support for [comparing two lists][list-comparison]. [float]: https://github.com/nixos/nix/commit/14ebde52893263930cdcde1406cc91cc5c42556f [langVersion-5]: https://github.com/nixos/nix/commit/8191992c83bf4387b03c5fdaba818dc2b520462d [list-comparison]: https://github.com/nixos/nix/commit/09471d2680292af48b2788108de56a8da755d661 +[nixpkgs-langVersion-5]: https://github.com/NixOS/nixpkgs/blob/d7ac3423d321b8b145ccdd1aed9dfdb280f5e391/pkgs/build-support/closure-info.nix#L11 -- cgit 1.4.1