<title>fix(tvix/eval): remove impl PartialEq for Value</title>
<updated>2022-11-04T00:30:13+00:00</updated>
<author>
<name>Adam Joseph</name>
<email>adam@westernsemico.com</email>
...</author>
<published>2022-11-01T00:13:38+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=06494742062e77036827dfc7c91dea507b44447f"/>
<id>urn:sha1:06494742062e77036827dfc7c91dea507b44447f</id>
<content type="text">
It isn't possible to implement PartialEq properly for Value, because
any sensible implementation needs to force() thunks, which cannot be
done without a `&mut VM`.
The existing derive(PartialEq) has false negatives, which caused the
bug which cl/7142 fixed. Fortunately that bug was easy to find, but
a silent false negative deep within the bowels of nixpkgs could be a
real nightmare to hunt down.
Let's just remove the PartialEq impl for Value, and the other
derive(PartialEq)'s that depend on it.
Signed-off-by: Adam Joseph <adam@westernsemico.com>
Change-Id: Iacd3726fefc7fc1edadcd7e9b586e04cf8466775
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7144
Reviewed-by: kanepyork <rikingcoding@gmail.com>
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
</content>