depot/third_party/protobuf, branch refs/r/8320 monorepo for the virus lounge http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F8320 2022-02-08T17:21:59+00:00 chore(3p): remove abseil_cpp, grpc, protobuf, re2 2022-02-08T17:21:59+00:00 Vincent Ambo mail@tazj.in 2022-02-07T23:13:08+00:00 urn:sha1:64b89b528794b3bd29e54a465696e3a7255f9c40 We're now using the upstream versions of all of these with minor overrides, no separate nonsense required. Change-Id: I61ace7ccf7ff807ef3c7219b36e08629a2251699 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5246 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org> fix(3p): resolve linker issues with clang-compiled C++ packages 2021-10-10T10:03:03+00:00 sterni sternenseemann@systemli.org 2021-10-07T19:57:09+00:00 urn:sha1:04f7cc3880912abb738d3d3bc20e7622a211f25e The point where this broke is likely when llvmPackages_11.stdenv started respecting stdenv.hostPlatform.linker and thus using GNU binutils' ld.bfd for linking. That linker can't deal with clang's C++ ABI. To fix this we introduce a modified version of llvmPackages_11.stdenv which uses llvmPackages_11.bintools for linking purposes (I also aim to upstream this in some form, but am not sure about the details atm, so we'll just do this in the tvl overlay for now). This is the precondition for getting our C++ packages in //third_party to work again. Additionally the following fixes were necessary: * abseil-cpp needed to be updated (by overriding the version from nixpkgs for now, since I can't update the subtree on my own) to fulfill grpc's requirements (grpc 1.41.0 needs abseil-cpp LTS 20210324). * gtest needs a patch from nixpkgs which fixes the path to its include directory for CMake. * We need to build re2 with clang as well, otherwise linking will fail. Fixes b/132. Change-Id: I7b64579fe96451547babe070fd35db398581e49d Reviewed-on: https://cl.tvl.fyi/c/depot/+/3701 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: tazjin <mail@tazj.in> chore(3p/overlays): Remove LLVM11 bump from overlay 2021-05-24T18:15:05+00:00 Vincent Ambo mail@tazj.in 2021-05-23T11:33:59+00:00 urn:sha1:3c7d4c74be3490589867fb99fed2c93d00172ca8 * This was mostly for //third_party/nix and its dependencies which now have been set to use llvmPackages_11 manually. * For //users/grfn/achilles we also manually select the newer LLVM version. * //tools/cheddar doesn't seem to need llvm anymore. * //third_party/buzz also compiles with clang 7.1.0 * replace clang-tools everywhere with new attribute clang-tools_11 For the future we may want to have something similar again, but it may not be necessary to invest too much time into it: nixpkgs is set to upgrade their default llvmPackages to LLVM 11 as well at some point in the near future. Co-Authored-By: sterni <sternenseemann@systemli.org> Change-Id: Id83868dbc476a6c776b59518b856c933f30ea79d Reviewed-on: https://cl.tvl.fyi/c/depot/+/3135 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: grfn <grfn@gws.fyi> refactor: Move nixpkgs attribute to `third_party.nixpkgs` 2021-04-10T21:18:55+00:00 Vincent Ambo mail@tazj.in 2021-04-10T16:05:16+00:00 urn:sha1:473604f5675c455a65b91e287b125a9e042ae39f Please read b/108 to make sense of this. This gets rid of the explicit list of exposed packages from nixpkgs, and instead makes the entire package set available at `third_party.nixpkgs`. To accommodate this, a LOT of things have to be very slightly shuffled around. Some of this was done in already submitted CLs, but this change is unfortunately still quite noisy. Pay extra attention to: * overlay-like functionality that was partially moved to actual overlays (partially as in, the minimum required to get a green build) * modified uses of the package set path, esp. in NixOS systems Special notes: * xanthous has been disabled in CI because of issues with the Haskell overlay * //third_party/nix has been disabled because of other unclear dependency issues Both of these will be tackled in a followup CL. Change-Id: I2f9c60a4d275fdb5209264be0addfd7e06c53118 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2910 Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI refactor(third_party): Consistent use of depot.third_party vs. pkgs 2021-04-10T11:48:55+00:00 Vincent Ambo mail@tazj.in 2021-04-10T00:13:18+00:00 urn:sha1:8361b82d0ac59f436f7ecef283077b0f7d689ca1 In preparation for the solution of b/108, we need to consistently use `depot.third_party` for packages that are only packed in the TVL depot and `pkgs` for things that come from nixpkgs. This commit cleans up a huge chunk of these uses in //third_party Change-Id: Ic382c0cdea7330a84d5f0b7d109c824ddceb94e7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2912 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> feat(3p/protobuf): Check in derivation for proto 3.12 with libcxx 2020-06-07T13:56:56+00:00 Vincent Ambo tazjin@google.com 2020-06-07T13:56:56+00:00 urn:sha1:4fb8788c01f2e9975d2ff1c3ac389ee8fe844a2f
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<feed xmlns="http://www.w3.org/2005/Atom">
<title>depot/third_party/protobuf, branch refs/r/8320</title>
<subtitle>monorepo for the virus lounge</subtitle>
<id>http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F8320</id>
<link rel="self" href="http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F8320"/>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/"/>
<updated>2022-02-08T17:21:59+00:00</updated>
<entry>
<title>chore(3p): remove abseil_cpp, grpc, protobuf, re2</title>
<updated>2022-02-08T17:21:59+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2022-02-07T23:13:08+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=64b89b528794b3bd29e54a465696e3a7255f9c40"/>
<id>urn:sha1:64b89b528794b3bd29e54a465696e3a7255f9c40</id>
<content type="text"> We're now using the upstream versions of all of these with minor overrides, no separate nonsense required. Change-Id: I61ace7ccf7ff807ef3c7219b36e08629a2251699 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5246 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org> </content>
</entry>
<entry>
<title>fix(3p): resolve linker issues with clang-compiled C++ packages</title>
<updated>2021-10-10T10:03:03+00:00</updated>
<author>
<name>sterni</name>
<email>sternenseemann@systemli.org</email>
</author>
<published>2021-10-07T19:57:09+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=04f7cc3880912abb738d3d3bc20e7622a211f25e"/>
<id>urn:sha1:04f7cc3880912abb738d3d3bc20e7622a211f25e</id>
<content type="text"> The point where this broke is likely when llvmPackages_11.stdenv started respecting stdenv.hostPlatform.linker and thus using GNU binutils' ld.bfd for linking. That linker can't deal with clang's C++ ABI. To fix this we introduce a modified version of llvmPackages_11.stdenv which uses llvmPackages_11.bintools for linking purposes (I also aim to upstream this in some form, but am not sure about the details atm, so we'll just do this in the tvl overlay for now). This is the precondition for getting our C++ packages in //third_party to work again. Additionally the following fixes were necessary: * abseil-cpp needed to be updated (by overriding the version from nixpkgs for now, since I can't update the subtree on my own) to fulfill grpc's requirements (grpc 1.41.0 needs abseil-cpp LTS 20210324). * gtest needs a patch from nixpkgs which fixes the path to its include directory for CMake. * We need to build re2 with clang as well, otherwise linking will fail. Fixes b/132. Change-Id: I7b64579fe96451547babe070fd35db398581e49d Reviewed-on: https://cl.tvl.fyi/c/depot/+/3701 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>chore(3p/overlays): Remove LLVM11 bump from overlay</title>
<updated>2021-05-24T18:15:05+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-05-23T11:33:59+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=3c7d4c74be3490589867fb99fed2c93d00172ca8"/>
<id>urn:sha1:3c7d4c74be3490589867fb99fed2c93d00172ca8</id>
<content type="text"> * This was mostly for //third_party/nix and its dependencies which now have been set to use llvmPackages_11 manually. * For //users/grfn/achilles we also manually select the newer LLVM version. * //tools/cheddar doesn't seem to need llvm anymore. * //third_party/buzz also compiles with clang 7.1.0 * replace clang-tools everywhere with new attribute clang-tools_11 For the future we may want to have something similar again, but it may not be necessary to invest too much time into it: nixpkgs is set to upgrade their default llvmPackages to LLVM 11 as well at some point in the near future. Co-Authored-By: sterni <sternenseemann@systemli.org> Change-Id: Id83868dbc476a6c776b59518b856c933f30ea79d Reviewed-on: https://cl.tvl.fyi/c/depot/+/3135 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: grfn <grfn@gws.fyi> </content>
</entry>
<entry>
<title>refactor: Move nixpkgs attribute to `third_party.nixpkgs`</title>
<updated>2021-04-10T21:18:55+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-04-10T16:05:16+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=473604f5675c455a65b91e287b125a9e042ae39f"/>
<id>urn:sha1:473604f5675c455a65b91e287b125a9e042ae39f</id>
<content type="text"> Please read b/108 to make sense of this. This gets rid of the explicit list of exposed packages from nixpkgs, and instead makes the entire package set available at `third_party.nixpkgs`. To accommodate this, a LOT of things have to be very slightly shuffled around. Some of this was done in already submitted CLs, but this change is unfortunately still quite noisy. Pay extra attention to: * overlay-like functionality that was partially moved to actual overlays (partially as in, the minimum required to get a green build) * modified uses of the package set path, esp. in NixOS systems Special notes: * xanthous has been disabled in CI because of issues with the Haskell overlay * //third_party/nix has been disabled because of other unclear dependency issues Both of these will be tackled in a followup CL. Change-Id: I2f9c60a4d275fdb5209264be0addfd7e06c53118 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2910 Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>refactor(third_party): Consistent use of depot.third_party vs. pkgs</title>
<updated>2021-04-10T11:48:55+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-04-10T00:13:18+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=8361b82d0ac59f436f7ecef283077b0f7d689ca1"/>
<id>urn:sha1:8361b82d0ac59f436f7ecef283077b0f7d689ca1</id>
<content type="text"> In preparation for the solution of b/108, we need to consistently use `depot.third_party` for packages that are only packed in the TVL depot and `pkgs` for things that come from nixpkgs. This commit cleans up a huge chunk of these uses in //third_party Change-Id: Ic382c0cdea7330a84d5f0b7d109c824ddceb94e7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2912 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> </content>
</entry>
<entry>
<title>feat(3p/protobuf): Check in derivation for proto 3.12 with libcxx</title>
<updated>2020-06-07T13:56:56+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-06-07T13:56:56+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=4fb8788c01f2e9975d2ff1c3ac389ee8fe844a2f"/>
<id>urn:sha1:4fb8788c01f2e9975d2ff1c3ac389ee8fe844a2f</id>
<content type="text"> </content>
</entry>
</feed>