depot/third_party/nix/src/nix-channel/nix-channel.cc, branch refs/r/1842 monorepo for the virus lounge http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F1842 2020-08-08T22:16:02+00:00 chore(3p/nix): apply google-readability-casting 2020-08-08T22:16:02+00:00 Kane York kanepyork@gmail.com 2020-08-02T00:17:44+00:00 urn:sha1:1de00e6c42ee6beaaa490104888ef09be1d4a0d4 Command run: jq <compile_commands.json -r 'map(.file)|.[]' | grep -v '/generated/' | parallel clang-tidy -p compile_commands.json -checks=-*,google-readability-casting --fix Manual fixes applied in src/nix-env/nix-env.cc, src/libstore/store-api.cc Change-Id: I406b4be9368c557ca59329bf6f7002704e955f8d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1557 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> fix(3p/nix): Use SkipEmpty in all calls to absl::StrSplit 2020-08-06T20:50:47+00:00 Kane York kanepyork@gmail.com 2020-08-06T08:28:00+00:00 urn:sha1:a5dae62e85d9ff9db6c4088d64559d7bac713486 The behavior to return a list containing a single empty string when provided an empty string is a behavior that absl inherited from legacy code. However, the behavior expected by legacy code in Nix is the behavior provided by the SkipEmpty option. Switch all calls to use SkipEmpty, except for the call already using SkipWhitespace. See also commit 26a59482d2427f640893517f1b24dd650a5bd5da, with the partly-prophetic message: "there may be other places we need to fix this as well." Change-Id: I6e94856a12cfb1b7e4a3b4e221769ed446648861 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1687 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> fix(3p/nix): revert "apply all clang-tidy fixes" 2020-08-01T22:45:15+00:00 Kane York kanepyork@gmail.com 2020-08-01T22:32:00+00:00 urn:sha1:72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60 This reverts commit ef54f5da9fa30b5c302f2a49595ee5d041f9706a. Resolved conflicts: third_party/nix/src/libexpr/eval.cc third_party/nix/src/libstore/builtins/fetchurl.cc third_party/nix/src/libstore/references.cc third_party/nix/src/libutil/hash.cc third_party/nix/src/nix-daemon/nix-daemon.cc Change-Id: Ib9cf6e96a79a23bde3983579ced3f92e530cb011 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1547 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI fix(3p/nix): apply all clang-tidy fixes 2020-07-27T21:16:39+00:00 Kane York kanepyork@gmail.com 2020-07-25T04:09:44+00:00 urn:sha1:ef54f5da9fa30b5c302f2a49595ee5d041f9706a Change-Id: I265e763393422ee1881653527c91024458060825 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1432 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> chore(3p/nix): Remove support for plugins 2020-07-20T14:45:43+00:00 Griffin Smith grfn@gws.fyi 2020-07-19T18:35:05+00:00 urn:sha1:2ef1060361b582990f6b7335e16ce37bee6756f2 Plugins seem to not really be used anywhere (I can find one plugin that's actually defined, and it doesn't seem very useful, especially since we got rid of builtins.exec) and their presence is adding additional complexity and potential sources of bugs to an already unsteady refactor. At some point we may want to bring back something *like* plugins, but their design will likely be different and it will definitely be after we have a functioning Nix again. Change-Id: I3bc40e55917f70bf260fbc208c1705e2e6a7c626 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1291 Tested-by: BuildkiteCI Reviewed-by: Alyssa Ross <hi@alyssa.is> Reviewed-by: isomer <isomer@tvl.fyi> fix(nix-channel): Actually strip whitespace. 2020-07-13T20:18:26+00:00 isomer isomer@tvl.fyi 2020-07-12T22:47:02+00:00 urn:sha1:afd1367337300f0411d1e6eee6bb6b53bbaf113c This has been providing a warning and it's been bothering me. Change-Id: I0548059950ec4250d7cf0938f9deae09eafe593c Reviewed-on: https://cl.tvl.fyi/c/depot/+/1141 Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: isomer <isomer@tvl.fyi> Tested-by: BuildkiteCI refactor(3p/nix): Anchor local includes at src/ 2020-05-27T20:56:34+00:00 Vincent Ambo tazjin@google.com 2020-05-27T20:56:34+00:00 urn:sha1:3652326ed281f5f753423acef51103fb8df62a6d Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes. refactor(3p/nix): Replace tokenizeStrings with absl::StrSplit 2020-05-25T14:54:14+00:00 Vincent Ambo tazjin@google.com 2020-05-25T14:54:14+00:00 urn:sha1:bf452cbc2ae2b209ec262ce858deca470d086f24 This function was a custom (and inefficient in the case of single-character delimiters) string splitter which was used all over the codebase. Abseil provides an appropriate replacement function. style(3p/nix): Remove 'using std::*' from types.hh 2020-05-24T21:29:21+00:00 Vincent Ambo tazjin@google.com 2020-05-24T21:29:21+00:00 urn:sha1:838f86b0fd880b26539664140f04e5d16669dad8 It is considered bad form to use things from includes in headers, as these directives propagate to everywhere else and can make it confusing. types.hh (which is includes almost literally everywhere) had some of these directives, which this commit removes. refactor(3p/nix/libutil): Replace chomp() with absl::strings 2020-05-24T01:13:07+00:00 Vincent Ambo tazjin@google.com 2020-05-24T00:36:11+00:00 urn:sha1:06d7b4aebd9e4a1a87f77fe59a8c08392318be5d
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<feed xmlns="http://www.w3.org/2005/Atom">
<title>depot/third_party/nix/src/nix-channel/nix-channel.cc, branch refs/r/1842</title>
<subtitle>monorepo for the virus lounge</subtitle>
<id>http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F1842</id>
<link rel="self" href="http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F1842"/>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/"/>
<updated>2020-08-08T22:16:02+00:00</updated>
<entry>
<title>chore(3p/nix): apply google-readability-casting</title>
<updated>2020-08-08T22:16:02+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-08-02T00:17:44+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=1de00e6c42ee6beaaa490104888ef09be1d4a0d4"/>
<id>urn:sha1:1de00e6c42ee6beaaa490104888ef09be1d4a0d4</id>
<content type="text"> Command run: jq <compile_commands.json -r 'map(.file)|.[]' | grep -v '/generated/' | parallel clang-tidy -p compile_commands.json -checks=-*,google-readability-casting --fix Manual fixes applied in src/nix-env/nix-env.cc, src/libstore/store-api.cc Change-Id: I406b4be9368c557ca59329bf6f7002704e955f8d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1557 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>fix(3p/nix): Use SkipEmpty in all calls to absl::StrSplit</title>
<updated>2020-08-06T20:50:47+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-08-06T08:28:00+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=a5dae62e85d9ff9db6c4088d64559d7bac713486"/>
<id>urn:sha1:a5dae62e85d9ff9db6c4088d64559d7bac713486</id>
<content type="text"> The behavior to return a list containing a single empty string when provided an empty string is a behavior that absl inherited from legacy code. However, the behavior expected by legacy code in Nix is the behavior provided by the SkipEmpty option. Switch all calls to use SkipEmpty, except for the call already using SkipWhitespace. See also commit 26a59482d2427f640893517f1b24dd650a5bd5da, with the partly-prophetic message: "there may be other places we need to fix this as well." Change-Id: I6e94856a12cfb1b7e4a3b4e221769ed446648861 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1687 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> </content>
</entry>
<entry>
<title>fix(3p/nix): revert "apply all clang-tidy fixes"</title>
<updated>2020-08-01T22:45:15+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-08-01T22:32:00+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60"/>
<id>urn:sha1:72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60</id>
<content type="text"> This reverts commit ef54f5da9fa30b5c302f2a49595ee5d041f9706a. Resolved conflicts: third_party/nix/src/libexpr/eval.cc third_party/nix/src/libstore/builtins/fetchurl.cc third_party/nix/src/libstore/references.cc third_party/nix/src/libutil/hash.cc third_party/nix/src/nix-daemon/nix-daemon.cc Change-Id: Ib9cf6e96a79a23bde3983579ced3f92e530cb011 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1547 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>fix(3p/nix): apply all clang-tidy fixes</title>
<updated>2020-07-27T21:16:39+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-07-25T04:09:44+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=ef54f5da9fa30b5c302f2a49595ee5d041f9706a"/>
<id>urn:sha1:ef54f5da9fa30b5c302f2a49595ee5d041f9706a</id>
<content type="text"> Change-Id: I265e763393422ee1881653527c91024458060825 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1432 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>chore(3p/nix): Remove support for plugins</title>
<updated>2020-07-20T14:45:43+00:00</updated>
<author>
<name>Griffin Smith</name>
<email>grfn@gws.fyi</email>
</author>
<published>2020-07-19T18:35:05+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=2ef1060361b582990f6b7335e16ce37bee6756f2"/>
<id>urn:sha1:2ef1060361b582990f6b7335e16ce37bee6756f2</id>
<content type="text"> Plugins seem to not really be used anywhere (I can find one plugin that's actually defined, and it doesn't seem very useful, especially since we got rid of builtins.exec) and their presence is adding additional complexity and potential sources of bugs to an already unsteady refactor. At some point we may want to bring back something *like* plugins, but their design will likely be different and it will definitely be after we have a functioning Nix again. Change-Id: I3bc40e55917f70bf260fbc208c1705e2e6a7c626 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1291 Tested-by: BuildkiteCI Reviewed-by: Alyssa Ross <hi@alyssa.is> Reviewed-by: isomer <isomer@tvl.fyi> </content>
</entry>
<entry>
<title>fix(nix-channel): Actually strip whitespace.</title>
<updated>2020-07-13T20:18:26+00:00</updated>
<author>
<name>isomer</name>
<email>isomer@tvl.fyi</email>
</author>
<published>2020-07-12T22:47:02+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=afd1367337300f0411d1e6eee6bb6b53bbaf113c"/>
<id>urn:sha1:afd1367337300f0411d1e6eee6bb6b53bbaf113c</id>
<content type="text"> This has been providing a warning and it's been bothering me. Change-Id: I0548059950ec4250d7cf0938f9deae09eafe593c Reviewed-on: https://cl.tvl.fyi/c/depot/+/1141 Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: isomer <isomer@tvl.fyi> Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>refactor(3p/nix): Anchor local includes at src/</title>
<updated>2020-05-27T20:56:34+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-27T20:56:34+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=3652326ed281f5f753423acef51103fb8df62a6d"/>
<id>urn:sha1:3652326ed281f5f753423acef51103fb8df62a6d</id>
<content type="text"> Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes. </content>
</entry>
<entry>
<title>refactor(3p/nix): Replace tokenizeStrings with absl::StrSplit</title>
<updated>2020-05-25T14:54:14+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-25T14:54:14+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=bf452cbc2ae2b209ec262ce858deca470d086f24"/>
<id>urn:sha1:bf452cbc2ae2b209ec262ce858deca470d086f24</id>
<content type="text"> This function was a custom (and inefficient in the case of single-character delimiters) string splitter which was used all over the codebase. Abseil provides an appropriate replacement function. </content>
</entry>
<entry>
<title>style(3p/nix): Remove 'using std::*' from types.hh</title>
<updated>2020-05-24T21:29:21+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-24T21:29:21+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=838f86b0fd880b26539664140f04e5d16669dad8"/>
<id>urn:sha1:838f86b0fd880b26539664140f04e5d16669dad8</id>
<content type="text"> It is considered bad form to use things from includes in headers, as these directives propagate to everywhere else and can make it confusing. types.hh (which is includes almost literally everywhere) had some of these directives, which this commit removes. </content>
</entry>
<entry>
<title>refactor(3p/nix/libutil): Replace chomp() with absl::strings</title>
<updated>2020-05-24T01:13:07+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-24T00:36:11+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=06d7b4aebd9e4a1a87f77fe59a8c08392318be5d"/>
<id>urn:sha1:06d7b4aebd9e4a1a87f77fe59a8c08392318be5d</id>
<content type="text"> </content>
</entry>
</feed>