depot/third_party/nix/src/libutil/xml-writer.cc, branch refs/r/7390 monorepo for the virus lounge http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F7390 2022-05-19T14:08:20+00:00 chore(3p/nix): unvendor tvix 0.1 2022-05-19T14:08:20+00:00 Vincent Ambo mail@tazj.in 2022-05-18T15:39:39+00:00 urn:sha1:d127f9bd0e7b9b2e0df2de8a2227f77c0907468d Nothing is using this now, and we'll likely never pick this up again, but we learned a lot in the process. Every now and then this breaks in some bizarre way on channel bumps and it's just a waste of time to maintain that. Change-Id: Idcf2f5acd4ca7070ce18d7149cbfc0d967dc0a44 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5632 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Autosubmit: tazjin <tazjin@tvl.su> refactor(3p/nix): Anchor local includes at src/ 2020-05-27T20:56:34+00:00 Vincent Ambo tazjin@google.com 2020-05-27T20:56:34+00:00 urn:sha1:3652326ed281f5f753423acef51103fb8df62a6d Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes. style(3p/nix): Remove 'using std::*' from types.hh 2020-05-24T21:29:21+00:00 Vincent Ambo tazjin@google.com 2020-05-24T21:29:21+00:00 urn:sha1:838f86b0fd880b26539664140f04e5d16669dad8 It is considered bad form to use things from includes in headers, as these directives propagate to everywhere else and can make it confusing. types.hh (which is includes almost literally everywhere) had some of these directives, which this commit removes. refactor(3p/nix): Apply clang-tidy's modernize-* fixes 2020-05-20T03:33:07+00:00 Vincent Ambo tazjin@google.com 2020-05-20T03:33:07+00:00 urn:sha1:d331d3a0b5c497a46e2636f308234be66566c04c This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position). style(3p/nix): Final act in the brace-wrapping saga 2020-05-19T19:51:32+00:00 Vincent Ambo tazjin@google.com 2020-05-19T19:47:23+00:00 urn:sha1:39087321811e81e26a1a47d6967df1088dcf0e95 This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-*,readability-braces-around-statements -fix src/*/*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon. style(3p/nix): Add braces around single-line conditionals 2020-05-19T17:55:58+00:00 Vincent Ambo tazjin@google.com 2020-05-19T17:55:58+00:00 urn:sha1:867055133d3f487e52dd44149f76347c2c28bf10 These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if (\(.+\))\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber style(3p/nix): Enforce braces around loops and conditionals 2020-05-19T16:38:04+00:00 Vincent Ambo tazjin@google.com 2020-05-19T16:38:04+00:00 urn:sha1:b490742a511dd03afc43f5143d6d61edaeeb8091 This change was generated with: fd -e cc -e hh | xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy. style(3p/nix): Reformat all includes to match new style 2020-05-19T14:55:11+00:00 Vincent Ambo tazjin@google.com 2020-05-19T14:54:39+00:00 urn:sha1:c758de9d22506eb279c5abe61f621e5c8f61af95 style(3p/nix): Reformat project in Google C++ style 2020-05-17T15:31:57+00:00 Vincent Ambo tazjin@google.com 2020-05-17T15:31:57+00:00 urn:sha1:0f2cf531f705d370321843e5ba9135b2ebdb5d19 Reformatted with: fd . -e hh -e cc | xargs clang-format -i Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10' 2020-05-17T14:52:38+00:00 Vincent Ambo tazjin@google.com 2020-05-17T14:52:38+00:00 urn:sha1:7994fd1d545cc5c876d6f21db7ddf9185d23dad6 git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<feed xmlns="http://www.w3.org/2005/Atom">
<title>depot/third_party/nix/src/libutil/xml-writer.cc, branch refs/r/7390</title>
<subtitle>monorepo for the virus lounge</subtitle>
<id>http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F7390</id>
<link rel="self" href="http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F7390"/>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/"/>
<updated>2022-05-19T14:08:20+00:00</updated>
<entry>
<title>chore(3p/nix): unvendor tvix 0.1</title>
<updated>2022-05-19T14:08:20+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2022-05-18T15:39:39+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=d127f9bd0e7b9b2e0df2de8a2227f77c0907468d"/>
<id>urn:sha1:d127f9bd0e7b9b2e0df2de8a2227f77c0907468d</id>
<content type="text"> Nothing is using this now, and we'll likely never pick this up again, but we learned a lot in the process. Every now and then this breaks in some bizarre way on channel bumps and it's just a waste of time to maintain that. Change-Id: Idcf2f5acd4ca7070ce18d7149cbfc0d967dc0a44 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5632 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Autosubmit: tazjin <tazjin@tvl.su> </content>
</entry>
<entry>
<title>refactor(3p/nix): Anchor local includes at src/</title>
<updated>2020-05-27T20:56:34+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-27T20:56:34+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=3652326ed281f5f753423acef51103fb8df62a6d"/>
<id>urn:sha1:3652326ed281f5f753423acef51103fb8df62a6d</id>
<content type="text"> Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes. </content>
</entry>
<entry>
<title>style(3p/nix): Remove 'using std::*' from types.hh</title>
<updated>2020-05-24T21:29:21+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-24T21:29:21+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=838f86b0fd880b26539664140f04e5d16669dad8"/>
<id>urn:sha1:838f86b0fd880b26539664140f04e5d16669dad8</id>
<content type="text"> It is considered bad form to use things from includes in headers, as these directives propagate to everywhere else and can make it confusing. types.hh (which is includes almost literally everywhere) had some of these directives, which this commit removes. </content>
</entry>
<entry>
<title>refactor(3p/nix): Apply clang-tidy's modernize-* fixes</title>
<updated>2020-05-20T03:33:07+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-20T03:33:07+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=d331d3a0b5c497a46e2636f308234be66566c04c"/>
<id>urn:sha1:d331d3a0b5c497a46e2636f308234be66566c04c</id>
<content type="text"> This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position). </content>
</entry>
<entry>
<title>style(3p/nix): Final act in the brace-wrapping saga</title>
<updated>2020-05-19T19:51:32+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-19T19:47:23+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=39087321811e81e26a1a47d6967df1088dcf0e95"/>
<id>urn:sha1:39087321811e81e26a1a47d6967df1088dcf0e95</id>
<content type="text"> This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-*,readability-braces-around-statements -fix src/*/*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon. </content>
</entry>
<entry>
<title>style(3p/nix): Add braces around single-line conditionals</title>
<updated>2020-05-19T17:55:58+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-19T17:55:58+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=867055133d3f487e52dd44149f76347c2c28bf10"/>
<id>urn:sha1:867055133d3f487e52dd44149f76347c2c28bf10</id>
<content type="text"> These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if (\(.+\))\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber </content>
</entry>
<entry>
<title>style(3p/nix): Enforce braces around loops and conditionals</title>
<updated>2020-05-19T16:38:04+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-19T16:38:04+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=b490742a511dd03afc43f5143d6d61edaeeb8091"/>
<id>urn:sha1:b490742a511dd03afc43f5143d6d61edaeeb8091</id>
<content type="text"> This change was generated with: fd -e cc -e hh | xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy. </content>
</entry>
<entry>
<title>style(3p/nix): Reformat all includes to match new style</title>
<updated>2020-05-19T14:55:11+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-19T14:54:39+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=c758de9d22506eb279c5abe61f621e5c8f61af95"/>
<id>urn:sha1:c758de9d22506eb279c5abe61f621e5c8f61af95</id>
<content type="text"> </content>
</entry>
<entry>
<title>style(3p/nix): Reformat project in Google C++ style</title>
<updated>2020-05-17T15:31:57+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-17T15:31:57+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=0f2cf531f705d370321843e5ba9135b2ebdb5d19"/>
<id>urn:sha1:0f2cf531f705d370321843e5ba9135b2ebdb5d19</id>
<content type="text"> Reformatted with: fd . -e hh -e cc | xargs clang-format -i </content>
</entry>
<entry>
<title>Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'</title>
<updated>2020-05-17T14:52:38+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-17T14:52:38+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=7994fd1d545cc5c876d6f21db7ddf9185d23dad6"/>
<id>urn:sha1:7994fd1d545cc5c876d6f21db7ddf9185d23dad6</id>
<content type="text"> git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10 </content>
</entry>
</feed>