depot/third_party/nix/src/libutil/serialise.cc, branch refs/r/6946 monorepo for the virus lounge http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F6946 2022-05-19T14:08:20+00:00 chore(3p/nix): unvendor tvix 0.1 2022-05-19T14:08:20+00:00 Vincent Ambo mail@tazj.in 2022-05-18T15:39:39+00:00 urn:sha1:d127f9bd0e7b9b2e0df2de8a2227f77c0907468d Nothing is using this now, and we'll likely never pick this up again, but we learned a lot in the process. Every now and then this breaks in some bizarre way on channel bumps and it's just a waste of time to maintain that. Change-Id: Idcf2f5acd4ca7070ce18d7149cbfc0d967dc0a44 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5632 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Autosubmit: tazjin <tazjin@tvl.su> chore(3p/nix): apply google-readability-casting 2020-08-08T22:16:02+00:00 Kane York kanepyork@gmail.com 2020-08-02T00:17:44+00:00 urn:sha1:1de00e6c42ee6beaaa490104888ef09be1d4a0d4 Command run: jq <compile_commands.json -r 'map(.file)|.[]' | grep -v '/generated/' | parallel clang-tidy -p compile_commands.json -checks=-*,google-readability-casting --fix Manual fixes applied in src/nix-env/nix-env.cc, src/libstore/store-api.cc Change-Id: I406b4be9368c557ca59329bf6f7002704e955f8d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1557 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> fix(3p/nix): revert "apply all clang-tidy fixes" 2020-08-01T22:45:15+00:00 Kane York kanepyork@gmail.com 2020-08-01T22:32:00+00:00 urn:sha1:72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60 This reverts commit ef54f5da9fa30b5c302f2a49595ee5d041f9706a. Resolved conflicts: third_party/nix/src/libexpr/eval.cc third_party/nix/src/libstore/builtins/fetchurl.cc third_party/nix/src/libstore/references.cc third_party/nix/src/libutil/hash.cc third_party/nix/src/nix-daemon/nix-daemon.cc Change-Id: Ib9cf6e96a79a23bde3983579ced3f92e530cb011 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1547 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI fix(3p/nix): apply all clang-tidy fixes 2020-07-27T21:16:39+00:00 Kane York kanepyork@gmail.com 2020-07-25T04:09:44+00:00 urn:sha1:ef54f5da9fa30b5c302f2a49595ee5d041f9706a Change-Id: I265e763393422ee1881653527c91024458060825 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1432 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> refactor(3p/nix): Anchor local includes at src/ 2020-05-27T20:56:34+00:00 Vincent Ambo tazjin@google.com 2020-05-27T20:56:34+00:00 urn:sha1:3652326ed281f5f753423acef51103fb8df62a6d Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes. style(3p/nix): Remove 'using std::*' from types.hh 2020-05-24T21:29:21+00:00 Vincent Ambo tazjin@google.com 2020-05-24T21:29:21+00:00 urn:sha1:838f86b0fd880b26539664140f04e5d16669dad8 It is considered bad form to use things from includes in headers, as these directives propagate to everywhere else and can make it confusing. types.hh (which is includes almost literally everywhere) had some of these directives, which this commit removes. refactor(3p/nix): Apply clang-tidy's performance-* fixes 2020-05-20T21:58:43+00:00 Vincent Ambo tazjin@google.com 2020-05-20T21:58:43+00:00 urn:sha1:43677021e3c285c2ced2075b918da947e13fcb00 This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html refactor(3p/nix): Apply clang-tidy's readability-* fixes 2020-05-20T21:27:37+00:00 Vincent Ambo tazjin@google.com 2020-05-20T21:27:37+00:00 urn:sha1:689ef502f5b0655c9923ed77da2ae3504630f473 This applies the readability fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html refactor(3p/nix): Apply clang-tidy's modernize-* fixes 2020-05-20T03:33:07+00:00 Vincent Ambo tazjin@google.com 2020-05-20T03:33:07+00:00 urn:sha1:d331d3a0b5c497a46e2636f308234be66566c04c This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position). style(3p/nix): Final act in the brace-wrapping saga 2020-05-19T19:51:32+00:00 Vincent Ambo tazjin@google.com 2020-05-19T19:47:23+00:00 urn:sha1:39087321811e81e26a1a47d6967df1088dcf0e95 This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-*,readability-braces-around-statements -fix src/*/*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon.
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<feed xmlns="http://www.w3.org/2005/Atom">
<title>depot/third_party/nix/src/libutil/serialise.cc, branch refs/r/6946</title>
<subtitle>monorepo for the virus lounge</subtitle>
<id>http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F6946</id>
<link rel="self" href="http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F6946"/>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/"/>
<updated>2022-05-19T14:08:20+00:00</updated>
<entry>
<title>chore(3p/nix): unvendor tvix 0.1</title>
<updated>2022-05-19T14:08:20+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2022-05-18T15:39:39+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=d127f9bd0e7b9b2e0df2de8a2227f77c0907468d"/>
<id>urn:sha1:d127f9bd0e7b9b2e0df2de8a2227f77c0907468d</id>
<content type="text"> Nothing is using this now, and we'll likely never pick this up again, but we learned a lot in the process. Every now and then this breaks in some bizarre way on channel bumps and it's just a waste of time to maintain that. Change-Id: Idcf2f5acd4ca7070ce18d7149cbfc0d967dc0a44 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5632 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Autosubmit: tazjin <tazjin@tvl.su> </content>
</entry>
<entry>
<title>chore(3p/nix): apply google-readability-casting</title>
<updated>2020-08-08T22:16:02+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-08-02T00:17:44+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=1de00e6c42ee6beaaa490104888ef09be1d4a0d4"/>
<id>urn:sha1:1de00e6c42ee6beaaa490104888ef09be1d4a0d4</id>
<content type="text"> Command run: jq <compile_commands.json -r 'map(.file)|.[]' | grep -v '/generated/' | parallel clang-tidy -p compile_commands.json -checks=-*,google-readability-casting --fix Manual fixes applied in src/nix-env/nix-env.cc, src/libstore/store-api.cc Change-Id: I406b4be9368c557ca59329bf6f7002704e955f8d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1557 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>fix(3p/nix): revert "apply all clang-tidy fixes"</title>
<updated>2020-08-01T22:45:15+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-08-01T22:32:00+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60"/>
<id>urn:sha1:72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60</id>
<content type="text"> This reverts commit ef54f5da9fa30b5c302f2a49595ee5d041f9706a. Resolved conflicts: third_party/nix/src/libexpr/eval.cc third_party/nix/src/libstore/builtins/fetchurl.cc third_party/nix/src/libstore/references.cc third_party/nix/src/libutil/hash.cc third_party/nix/src/nix-daemon/nix-daemon.cc Change-Id: Ib9cf6e96a79a23bde3983579ced3f92e530cb011 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1547 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>fix(3p/nix): apply all clang-tidy fixes</title>
<updated>2020-07-27T21:16:39+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-07-25T04:09:44+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=ef54f5da9fa30b5c302f2a49595ee5d041f9706a"/>
<id>urn:sha1:ef54f5da9fa30b5c302f2a49595ee5d041f9706a</id>
<content type="text"> Change-Id: I265e763393422ee1881653527c91024458060825 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1432 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>refactor(3p/nix): Anchor local includes at src/</title>
<updated>2020-05-27T20:56:34+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-27T20:56:34+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=3652326ed281f5f753423acef51103fb8df62a6d"/>
<id>urn:sha1:3652326ed281f5f753423acef51103fb8df62a6d</id>
<content type="text"> Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes. </content>
</entry>
<entry>
<title>style(3p/nix): Remove 'using std::*' from types.hh</title>
<updated>2020-05-24T21:29:21+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-24T21:29:21+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=838f86b0fd880b26539664140f04e5d16669dad8"/>
<id>urn:sha1:838f86b0fd880b26539664140f04e5d16669dad8</id>
<content type="text"> It is considered bad form to use things from includes in headers, as these directives propagate to everywhere else and can make it confusing. types.hh (which is includes almost literally everywhere) had some of these directives, which this commit removes. </content>
</entry>
<entry>
<title>refactor(3p/nix): Apply clang-tidy's performance-* fixes</title>
<updated>2020-05-20T21:58:43+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-20T21:58:43+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=43677021e3c285c2ced2075b918da947e13fcb00"/>
<id>urn:sha1:43677021e3c285c2ced2075b918da947e13fcb00</id>
<content type="text"> This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html </content>
</entry>
<entry>
<title>refactor(3p/nix): Apply clang-tidy's readability-* fixes</title>
<updated>2020-05-20T21:27:37+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-20T21:27:37+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=689ef502f5b0655c9923ed77da2ae3504630f473"/>
<id>urn:sha1:689ef502f5b0655c9923ed77da2ae3504630f473</id>
<content type="text"> This applies the readability fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html </content>
</entry>
<entry>
<title>refactor(3p/nix): Apply clang-tidy's modernize-* fixes</title>
<updated>2020-05-20T03:33:07+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-20T03:33:07+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=d331d3a0b5c497a46e2636f308234be66566c04c"/>
<id>urn:sha1:d331d3a0b5c497a46e2636f308234be66566c04c</id>
<content type="text"> This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position). </content>
</entry>
<entry>
<title>style(3p/nix): Final act in the brace-wrapping saga</title>
<updated>2020-05-19T19:51:32+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-19T19:47:23+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=39087321811e81e26a1a47d6967df1088dcf0e95"/>
<id>urn:sha1:39087321811e81e26a1a47d6967df1088dcf0e95</id>
<content type="text"> This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-*,readability-braces-around-statements -fix src/*/*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon. </content>
</entry>
</feed>