depot/third_party/nix/src/libstore/ssh.cc, branch refs/r/7327 monorepo for the virus lounge http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F7327 2022-05-19T14:08:20+00:00 chore(3p/nix): unvendor tvix 0.1 2022-05-19T14:08:20+00:00 Vincent Ambo mail@tazj.in 2022-05-18T15:39:39+00:00 urn:sha1:d127f9bd0e7b9b2e0df2de8a2227f77c0907468d Nothing is using this now, and we'll likely never pick this up again, but we learned a lot in the process. Every now and then this breaks in some bizarre way on channel bumps and it's just a waste of time to maintain that. Change-Id: Idcf2f5acd4ca7070ce18d7149cbfc0d967dc0a44 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5632 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Autosubmit: tazjin <tazjin@tvl.su> refactor(tvix): getEnv(): Return std::optional 2020-09-01T02:21:53+00:00 Eelco Dolstra edolstra@gmail.com 2019-11-22T15:06:44+00:00 urn:sha1:785cb3a75476033ba6eec2fef334d47d8e64388a This allows distinguishing between an empty value and no value. Patch ported from upstream at https://github.com/NixOS/nix/commit/ba87b08f8529e4d9f8c58d8c625152058ceadb75 Change-Id: I061cc8e16b1a7a0341adfc3b0edca1c0c51d5c97 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1884 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> refactor(tvix/libutil): Mark single-argument constructors explicit 2020-08-23T11:58:44+00:00 Vincent Ambo mail@tazj.in 2020-08-21T03:00:55+00:00 urn:sha1:1cf11317cac2c11d20b2324d4283814f1351c1a3 This is the clang-tidy lint 'google-explicit-constructor'. There's a whole bunch of breakage that was introduced by this, and we had to opt out a few types of this (esp. the string formatting crap). In some cases minor other changes have been done to keep the code working, instead of converting between types (e.g. an explicit comparison operator implementation for nix::Pid). Change-Id: I12e1ca51a6bc2c882dba81a2526b9729d26988e7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1832 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: glittershark <grfn@gws.fyi> chore(3p/nix): apply google-readability-casting 2020-08-08T22:16:02+00:00 Kane York kanepyork@gmail.com 2020-08-02T00:17:44+00:00 urn:sha1:1de00e6c42ee6beaaa490104888ef09be1d4a0d4 Command run: jq <compile_commands.json -r 'map(.file)|.[]' | grep -v '/generated/' | parallel clang-tidy -p compile_commands.json -checks=-*,google-readability-casting --fix Manual fixes applied in src/nix-env/nix-env.cc, src/libstore/store-api.cc Change-Id: I406b4be9368c557ca59329bf6f7002704e955f8d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1557 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> fix(3p/nix): Use SkipEmpty in all calls to absl::StrSplit 2020-08-06T20:50:47+00:00 Kane York kanepyork@gmail.com 2020-08-06T08:28:00+00:00 urn:sha1:a5dae62e85d9ff9db6c4088d64559d7bac713486 The behavior to return a list containing a single empty string when provided an empty string is a behavior that absl inherited from legacy code. However, the behavior expected by legacy code in Nix is the behavior provided by the SkipEmpty option. Switch all calls to use SkipEmpty, except for the call already using SkipWhitespace. See also commit 26a59482d2427f640893517f1b24dd650a5bd5da, with the partly-prophetic message: "there may be other places we need to fix this as well." Change-Id: I6e94856a12cfb1b7e4a3b4e221769ed446648861 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1687 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> fix(3p/nix): revert "apply all clang-tidy fixes" 2020-08-01T22:45:15+00:00 Kane York kanepyork@gmail.com 2020-08-01T22:32:00+00:00 urn:sha1:72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60 This reverts commit ef54f5da9fa30b5c302f2a49595ee5d041f9706a. Resolved conflicts: third_party/nix/src/libexpr/eval.cc third_party/nix/src/libstore/builtins/fetchurl.cc third_party/nix/src/libstore/references.cc third_party/nix/src/libutil/hash.cc third_party/nix/src/nix-daemon/nix-daemon.cc Change-Id: Ib9cf6e96a79a23bde3983579ced3f92e530cb011 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1547 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI fix(3p/nix): apply all clang-tidy fixes 2020-07-27T21:16:39+00:00 Kane York kanepyork@gmail.com 2020-07-25T04:09:44+00:00 urn:sha1:ef54f5da9fa30b5c302f2a49595ee5d041f9706a Change-Id: I265e763393422ee1881653527c91024458060825 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1432 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> refactor(3p/nix): Anchor local includes at src/ 2020-05-27T20:56:34+00:00 Vincent Ambo tazjin@google.com 2020-05-27T20:56:34+00:00 urn:sha1:3652326ed281f5f753423acef51103fb8df62a6d Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes. refactor(3p/nix): Replace tokenizeStrings with absl::StrSplit 2020-05-25T14:54:14+00:00 Vincent Ambo tazjin@google.com 2020-05-25T14:54:14+00:00 urn:sha1:bf452cbc2ae2b209ec262ce858deca470d086f24 This function was a custom (and inefficient in the case of single-character delimiters) string splitter which was used all over the codebase. Abseil provides an appropriate replacement function. refactor(3p/nix/libutil): Replace hasPrefix/Suffix with Abseil 2020-05-25T01:19:01+00:00 Vincent Ambo tazjin@google.com 2020-05-25T01:19:01+00:00 urn:sha1:b99b368d17f2e806a61f7abb83c6d3a9e4bbdc38 Uses the equivalent absl::StartsWith and absl::EndsWith functions instead.
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<feed xmlns="http://www.w3.org/2005/Atom">
<title>depot/third_party/nix/src/libstore/ssh.cc, branch refs/r/7327</title>
<subtitle>monorepo for the virus lounge</subtitle>
<id>http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F7327</id>
<link rel="self" href="http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F7327"/>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/"/>
<updated>2022-05-19T14:08:20+00:00</updated>
<entry>
<title>chore(3p/nix): unvendor tvix 0.1</title>
<updated>2022-05-19T14:08:20+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2022-05-18T15:39:39+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=d127f9bd0e7b9b2e0df2de8a2227f77c0907468d"/>
<id>urn:sha1:d127f9bd0e7b9b2e0df2de8a2227f77c0907468d</id>
<content type="text"> Nothing is using this now, and we'll likely never pick this up again, but we learned a lot in the process. Every now and then this breaks in some bizarre way on channel bumps and it's just a waste of time to maintain that. Change-Id: Idcf2f5acd4ca7070ce18d7149cbfc0d967dc0a44 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5632 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Autosubmit: tazjin <tazjin@tvl.su> </content>
</entry>
<entry>
<title>refactor(tvix): getEnv(): Return std::optional</title>
<updated>2020-09-01T02:21:53+00:00</updated>
<author>
<name>Eelco Dolstra</name>
<email>edolstra@gmail.com</email>
</author>
<published>2019-11-22T15:06:44+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=785cb3a75476033ba6eec2fef334d47d8e64388a"/>
<id>urn:sha1:785cb3a75476033ba6eec2fef334d47d8e64388a</id>
<content type="text"> This allows distinguishing between an empty value and no value. Patch ported from upstream at https://github.com/NixOS/nix/commit/ba87b08f8529e4d9f8c58d8c625152058ceadb75 Change-Id: I061cc8e16b1a7a0341adfc3b0edca1c0c51d5c97 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1884 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> </content>
</entry>
<entry>
<title>refactor(tvix/libutil): Mark single-argument constructors explicit</title>
<updated>2020-08-23T11:58:44+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2020-08-21T03:00:55+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=1cf11317cac2c11d20b2324d4283814f1351c1a3"/>
<id>urn:sha1:1cf11317cac2c11d20b2324d4283814f1351c1a3</id>
<content type="text"> This is the clang-tidy lint 'google-explicit-constructor'. There's a whole bunch of breakage that was introduced by this, and we had to opt out a few types of this (esp. the string formatting crap). In some cases minor other changes have been done to keep the code working, instead of converting between types (e.g. an explicit comparison operator implementation for nix::Pid). Change-Id: I12e1ca51a6bc2c882dba81a2526b9729d26988e7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1832 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: glittershark <grfn@gws.fyi> </content>
</entry>
<entry>
<title>chore(3p/nix): apply google-readability-casting</title>
<updated>2020-08-08T22:16:02+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-08-02T00:17:44+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=1de00e6c42ee6beaaa490104888ef09be1d4a0d4"/>
<id>urn:sha1:1de00e6c42ee6beaaa490104888ef09be1d4a0d4</id>
<content type="text"> Command run: jq <compile_commands.json -r 'map(.file)|.[]' | grep -v '/generated/' | parallel clang-tidy -p compile_commands.json -checks=-*,google-readability-casting --fix Manual fixes applied in src/nix-env/nix-env.cc, src/libstore/store-api.cc Change-Id: I406b4be9368c557ca59329bf6f7002704e955f8d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1557 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>fix(3p/nix): Use SkipEmpty in all calls to absl::StrSplit</title>
<updated>2020-08-06T20:50:47+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-08-06T08:28:00+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=a5dae62e85d9ff9db6c4088d64559d7bac713486"/>
<id>urn:sha1:a5dae62e85d9ff9db6c4088d64559d7bac713486</id>
<content type="text"> The behavior to return a list containing a single empty string when provided an empty string is a behavior that absl inherited from legacy code. However, the behavior expected by legacy code in Nix is the behavior provided by the SkipEmpty option. Switch all calls to use SkipEmpty, except for the call already using SkipWhitespace. See also commit 26a59482d2427f640893517f1b24dd650a5bd5da, with the partly-prophetic message: "there may be other places we need to fix this as well." Change-Id: I6e94856a12cfb1b7e4a3b4e221769ed446648861 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1687 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> </content>
</entry>
<entry>
<title>fix(3p/nix): revert "apply all clang-tidy fixes"</title>
<updated>2020-08-01T22:45:15+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-08-01T22:32:00+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60"/>
<id>urn:sha1:72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60</id>
<content type="text"> This reverts commit ef54f5da9fa30b5c302f2a49595ee5d041f9706a. Resolved conflicts: third_party/nix/src/libexpr/eval.cc third_party/nix/src/libstore/builtins/fetchurl.cc third_party/nix/src/libstore/references.cc third_party/nix/src/libutil/hash.cc third_party/nix/src/nix-daemon/nix-daemon.cc Change-Id: Ib9cf6e96a79a23bde3983579ced3f92e530cb011 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1547 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>fix(3p/nix): apply all clang-tidy fixes</title>
<updated>2020-07-27T21:16:39+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-07-25T04:09:44+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=ef54f5da9fa30b5c302f2a49595ee5d041f9706a"/>
<id>urn:sha1:ef54f5da9fa30b5c302f2a49595ee5d041f9706a</id>
<content type="text"> Change-Id: I265e763393422ee1881653527c91024458060825 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1432 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>refactor(3p/nix): Anchor local includes at src/</title>
<updated>2020-05-27T20:56:34+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-27T20:56:34+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=3652326ed281f5f753423acef51103fb8df62a6d"/>
<id>urn:sha1:3652326ed281f5f753423acef51103fb8df62a6d</id>
<content type="text"> Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes. </content>
</entry>
<entry>
<title>refactor(3p/nix): Replace tokenizeStrings with absl::StrSplit</title>
<updated>2020-05-25T14:54:14+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-25T14:54:14+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=bf452cbc2ae2b209ec262ce858deca470d086f24"/>
<id>urn:sha1:bf452cbc2ae2b209ec262ce858deca470d086f24</id>
<content type="text"> This function was a custom (and inefficient in the case of single-character delimiters) string splitter which was used all over the codebase. Abseil provides an appropriate replacement function. </content>
</entry>
<entry>
<title>refactor(3p/nix/libutil): Replace hasPrefix/Suffix with Abseil</title>
<updated>2020-05-25T01:19:01+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-25T01:19:01+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=b99b368d17f2e806a61f7abb83c6d3a9e4bbdc38"/>
<id>urn:sha1:b99b368d17f2e806a61f7abb83c6d3a9e4bbdc38</id>
<content type="text"> Uses the equivalent absl::StartsWith and absl::EndsWith functions instead. </content>
</entry>
</feed>