depot/third_party/nix/src/libexpr/primops/fetchMercurial.cc, branch refs/r/1931 monorepo for the virus lounge http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F1931 2020-08-21T03:55:56+00:00 style(tvix): Add missing braces in expressions 2020-08-21T03:55:56+00:00 Vincent Ambo mail@tazj.in 2020-08-21T02:29:53+00:00 urn:sha1:1443298657156107704b5d9fcfa7356ee8fa8789 The previous clang-tidy invocation missed some header files, which has now been rectified. Change-Id: I31547754fbf52f439dc7aeefb08ab90bd50c4156 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1831 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI chore(3p/nix): apply google-readability-casting 2020-08-08T22:16:02+00:00 Kane York kanepyork@gmail.com 2020-08-02T00:17:44+00:00 urn:sha1:1de00e6c42ee6beaaa490104888ef09be1d4a0d4 Command run: jq <compile_commands.json -r 'map(.file)|.[]' | grep -v '/generated/' | parallel clang-tidy -p compile_commands.json -checks=-*,google-readability-casting --fix Manual fixes applied in src/nix-env/nix-env.cc, src/libstore/store-api.cc Change-Id: I406b4be9368c557ca59329bf6f7002704e955f8d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1557 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> fix(3p/nix): Use SkipEmpty in all calls to absl::StrSplit 2020-08-06T20:50:47+00:00 Kane York kanepyork@gmail.com 2020-08-06T08:28:00+00:00 urn:sha1:a5dae62e85d9ff9db6c4088d64559d7bac713486 The behavior to return a list containing a single empty string when provided an empty string is a behavior that absl inherited from legacy code. However, the behavior expected by legacy code in Nix is the behavior provided by the SkipEmpty option. Switch all calls to use SkipEmpty, except for the call already using SkipWhitespace. See also commit 26a59482d2427f640893517f1b24dd650a5bd5da, with the partly-prophetic message: "there may be other places we need to fix this as well." Change-Id: I6e94856a12cfb1b7e4a3b4e221769ed446648861 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1687 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> fix(3p/nix): revert "apply all clang-tidy fixes" 2020-08-01T22:45:15+00:00 Kane York kanepyork@gmail.com 2020-08-01T22:32:00+00:00 urn:sha1:72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60 This reverts commit ef54f5da9fa30b5c302f2a49595ee5d041f9706a. Resolved conflicts: third_party/nix/src/libexpr/eval.cc third_party/nix/src/libstore/builtins/fetchurl.cc third_party/nix/src/libstore/references.cc third_party/nix/src/libutil/hash.cc third_party/nix/src/nix-daemon/nix-daemon.cc Change-Id: Ib9cf6e96a79a23bde3983579ced3f92e530cb011 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1547 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI fix(3p/nix): apply all clang-tidy fixes 2020-07-27T21:16:39+00:00 Kane York kanepyork@gmail.com 2020-07-25T04:09:44+00:00 urn:sha1:ef54f5da9fa30b5c302f2a49595ee5d041f9706a Change-Id: I265e763393422ee1881653527c91024458060825 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1432 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> refactor(3p/nix): Anchor local includes at src/ 2020-05-27T20:56:34+00:00 Vincent Ambo tazjin@google.com 2020-05-27T20:56:34+00:00 urn:sha1:3652326ed281f5f753423acef51103fb8df62a6d Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes. refactor(3p/nix): Replace tokenizeStrings with absl::StrSplit 2020-05-25T14:54:14+00:00 Vincent Ambo tazjin@google.com 2020-05-25T14:54:14+00:00 urn:sha1:bf452cbc2ae2b209ec262ce858deca470d086f24 This function was a custom (and inefficient in the case of single-character delimiters) string splitter which was used all over the codebase. Abseil provides an appropriate replacement function. refactor(3p/nix/libutil): Replace hasPrefix/Suffix with Abseil 2020-05-25T01:19:01+00:00 Vincent Ambo tazjin@google.com 2020-05-25T01:19:01+00:00 urn:sha1:b99b368d17f2e806a61f7abb83c6d3a9e4bbdc38 Uses the equivalent absl::StartsWith and absl::EndsWith functions instead. refactor(3p/nix/libutil): Replace chomp() with absl::strings 2020-05-24T01:13:07+00:00 Vincent Ambo tazjin@google.com 2020-05-24T00:36:11+00:00 urn:sha1:06d7b4aebd9e4a1a87f77fe59a8c08392318be5d chore(3p/nix/libexpr): Delete Bindings::sort 2020-05-22T02:35:07+00:00 Vincent Ambo tazjin@google.com 2020-05-22T02:35:07+00:00 urn:sha1:68e6e92a20b8ee01de3b89e72fc68517fea6f70c This function does nothing anymore since the attributes are always in-order.
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<feed xmlns="http://www.w3.org/2005/Atom">
<title>depot/third_party/nix/src/libexpr/primops/fetchMercurial.cc, branch refs/r/1931</title>
<subtitle>monorepo for the virus lounge</subtitle>
<id>http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F1931</id>
<link rel="self" href="http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F1931"/>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/"/>
<updated>2020-08-21T03:55:56+00:00</updated>
<entry>
<title>style(tvix): Add missing braces in expressions</title>
<updated>2020-08-21T03:55:56+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2020-08-21T02:29:53+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=1443298657156107704b5d9fcfa7356ee8fa8789"/>
<id>urn:sha1:1443298657156107704b5d9fcfa7356ee8fa8789</id>
<content type="text"> The previous clang-tidy invocation missed some header files, which has now been rectified. Change-Id: I31547754fbf52f439dc7aeefb08ab90bd50c4156 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1831 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>chore(3p/nix): apply google-readability-casting</title>
<updated>2020-08-08T22:16:02+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-08-02T00:17:44+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=1de00e6c42ee6beaaa490104888ef09be1d4a0d4"/>
<id>urn:sha1:1de00e6c42ee6beaaa490104888ef09be1d4a0d4</id>
<content type="text"> Command run: jq <compile_commands.json -r 'map(.file)|.[]' | grep -v '/generated/' | parallel clang-tidy -p compile_commands.json -checks=-*,google-readability-casting --fix Manual fixes applied in src/nix-env/nix-env.cc, src/libstore/store-api.cc Change-Id: I406b4be9368c557ca59329bf6f7002704e955f8d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1557 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>fix(3p/nix): Use SkipEmpty in all calls to absl::StrSplit</title>
<updated>2020-08-06T20:50:47+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-08-06T08:28:00+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=a5dae62e85d9ff9db6c4088d64559d7bac713486"/>
<id>urn:sha1:a5dae62e85d9ff9db6c4088d64559d7bac713486</id>
<content type="text"> The behavior to return a list containing a single empty string when provided an empty string is a behavior that absl inherited from legacy code. However, the behavior expected by legacy code in Nix is the behavior provided by the SkipEmpty option. Switch all calls to use SkipEmpty, except for the call already using SkipWhitespace. See also commit 26a59482d2427f640893517f1b24dd650a5bd5da, with the partly-prophetic message: "there may be other places we need to fix this as well." Change-Id: I6e94856a12cfb1b7e4a3b4e221769ed446648861 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1687 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> </content>
</entry>
<entry>
<title>fix(3p/nix): revert "apply all clang-tidy fixes"</title>
<updated>2020-08-01T22:45:15+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-08-01T22:32:00+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60"/>
<id>urn:sha1:72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60</id>
<content type="text"> This reverts commit ef54f5da9fa30b5c302f2a49595ee5d041f9706a. Resolved conflicts: third_party/nix/src/libexpr/eval.cc third_party/nix/src/libstore/builtins/fetchurl.cc third_party/nix/src/libstore/references.cc third_party/nix/src/libutil/hash.cc third_party/nix/src/nix-daemon/nix-daemon.cc Change-Id: Ib9cf6e96a79a23bde3983579ced3f92e530cb011 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1547 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>fix(3p/nix): apply all clang-tidy fixes</title>
<updated>2020-07-27T21:16:39+00:00</updated>
<author>
<name>Kane York</name>
<email>kanepyork@gmail.com</email>
</author>
<published>2020-07-25T04:09:44+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=ef54f5da9fa30b5c302f2a49595ee5d041f9706a"/>
<id>urn:sha1:ef54f5da9fa30b5c302f2a49595ee5d041f9706a</id>
<content type="text"> Change-Id: I265e763393422ee1881653527c91024458060825 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1432 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>refactor(3p/nix): Anchor local includes at src/</title>
<updated>2020-05-27T20:56:34+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-27T20:56:34+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=3652326ed281f5f753423acef51103fb8df62a6d"/>
<id>urn:sha1:3652326ed281f5f753423acef51103fb8df62a6d</id>
<content type="text"> Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes. </content>
</entry>
<entry>
<title>refactor(3p/nix): Replace tokenizeStrings with absl::StrSplit</title>
<updated>2020-05-25T14:54:14+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-25T14:54:14+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=bf452cbc2ae2b209ec262ce858deca470d086f24"/>
<id>urn:sha1:bf452cbc2ae2b209ec262ce858deca470d086f24</id>
<content type="text"> This function was a custom (and inefficient in the case of single-character delimiters) string splitter which was used all over the codebase. Abseil provides an appropriate replacement function. </content>
</entry>
<entry>
<title>refactor(3p/nix/libutil): Replace hasPrefix/Suffix with Abseil</title>
<updated>2020-05-25T01:19:01+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-25T01:19:01+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=b99b368d17f2e806a61f7abb83c6d3a9e4bbdc38"/>
<id>urn:sha1:b99b368d17f2e806a61f7abb83c6d3a9e4bbdc38</id>
<content type="text"> Uses the equivalent absl::StartsWith and absl::EndsWith functions instead. </content>
</entry>
<entry>
<title>refactor(3p/nix/libutil): Replace chomp() with absl::strings</title>
<updated>2020-05-24T01:13:07+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-24T00:36:11+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=06d7b4aebd9e4a1a87f77fe59a8c08392318be5d"/>
<id>urn:sha1:06d7b4aebd9e4a1a87f77fe59a8c08392318be5d</id>
<content type="text"> </content>
</entry>
<entry>
<title>chore(3p/nix/libexpr): Delete Bindings::sort</title>
<updated>2020-05-22T02:35:07+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>tazjin@google.com</email>
</author>
<published>2020-05-22T02:35:07+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=68e6e92a20b8ee01de3b89e72fc68517fea6f70c"/>
<id>urn:sha1:68e6e92a20b8ee01de3b89e72fc68517fea6f70c</id>
<content type="text"> This function does nothing anymore since the attributes are always in-order. </content>
</entry>
</feed>