depot/ops/besadii, branch refs/r/7126 monorepo for the virus lounge http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F7126 2022-06-09T15:26:25+00:00 fix(ops/besadii) test trigger.ref against configured branch 2022-06-09T15:26:25+00:00 Åsmund Østvold asmundo@gmail.com 2022-06-09T12:36:01+00:00 urn:sha1:2caa50c9bd0f9fad3194c8c1c2653805b038bd0f Before this commit besadii only worked for repos having 'refs/heads/canon' as main branch. Change-Id: Ia2ceb8a720c675be84bc3d81b89338522cea6ebd Reviewed-on: https://cl.tvl.fyi/c/depot/+/5862 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: asmundo <asmundo@gmail.com> fix(ops/besadii): Fix output formatting for non-CL builds 2022-04-26T09:25:03+00:00 Vincent Ambo mail@tazj.in 2022-04-26T09:21:11+00:00 urn:sha1:96aea320846d3d0d61e9e00d85f58a3efe3f9f82 Change-Id: Ie9ffb2d287f6c8a1e3ae45a7ad6671b9b8fa9c8a Reviewed-on: https://cl.tvl.fyi/c/depot/+/5505 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: asmundo <asmundo@gmail.com> feat(ops/besadii): make text 'cl' posted BuildKite configurable 2022-01-19T10:31:52+00:00 Åsmund Østvold asmundo@gmail.com 2022-01-07T10:37:48+00:00 urn:sha1:6e4b0f3cef56443a9780c4ff73466556e4915513 Some companies do not know the 'cl' term. They do know of 'change' and would maybe not like to introduce one more synonym. This cl introduce an optional entry 'gerritChangeName' in besadii.json. The string has to match `^[a-z0-9]+$` for readability. Change-Id: Id70fcb1e45158869f88bf37669be49b8b8a3b295 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4825 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: asmundo <asmundo@gmail.com> feat(besadii): Skip builds of patchsets with no code changes 2022-01-14T17:35:45+00:00 Vincent Ambo mail@tazj.in 2022-01-12T14:42:24+00:00 urn:sha1:ee52fbc46c4812921c5e68c16be2542e36d45366 Currently Gerrit is configured to copy forward the scores of the 'Verified' label if the tree of the commit does not change (e.g. only author information or commit message is modified). Besadii still triggers builds for these patchsets though. With this change it will inspect the (previously ignored) "kind" of the patchset and skip patchsets with the same tree as their predecessor. See Gerrit docs for the semantics of "kind": https://gerrit-review.googlesource.com/Documentation/json.html#patchSet Note that an argument can be made that we should do the exact opposite - stop carrying over 'Verified' at all and always build all patchsets. I think this depends on whether we intend to use commit metadata in CI runs at all. Adding a few people to the review for opinions. Change-Id: I48a96a1ad1e07d92330d84e5cfdc820a39395297 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4867 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Reviewed-by: asmundo <asmundo@gmail.com> Reviewed-by: sterni <sternenseemann@systemli.org> fix(ops/besadii) no need to ref CL number in post to Gerrit 2022-01-12T09:37:01+00:00 Åsmund Østvold asmundo@gmail.com 2022-01-07T11:57:50+00:00 urn:sha1:d4b997d832b5ba14f31c4a41a9e2555d8a6f7af4 The comment posted to the Gerrit change do not need to contain the CL number as it is given by the context of the Gerrit UI. Change-Id: I172645e7f4d82e2fbebe179578babd42ea29737f Reviewed-on: https://cl.tvl.fyi/c/depot/+/4826 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: asmundo <asmundo@gmail.com> style(ops/besadii): run depotfmt 2021-12-21T14:19:28+00:00 sterni sternenseemann@systemli.org 2021-12-21T13:55:29+00:00 urn:sha1:7de43fe4eec017790a41f1312c659190baf24f9e Unclear if this reformat is caused by the channel update or if this file was ignored previously. Change-Id: I3498ab181c7fff1b132419783e33a96f7bebfe42 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4520 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> fix(ops/besadii): fix Gerrit URL format ... again 2021-12-19T17:08:08+00:00 Vincent Ambo mail@tazj.in 2021-12-19T17:05:45+00:00 urn:sha1:eea2dbadd0d38bc017d1fc3fe7b71ac38b6e4bea got into some kind of race with different patchsets of this CL somehow, idk Change-Id: I3dcdb708f141829b866fbd786483710b43ea9824 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4481 Autosubmit: tazjin <mail@tazj.in> Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI fix(ops/besadii): Only set branch to CL when building patchsets 2021-12-19T16:53:47+00:00 Vincent Ambo mail@tazj.in 2021-12-19T16:47:04+00:00 urn:sha1:1d4715781ca8954d8c20e7a7420a7775fd671416 If we set this for canon, then stuff starts to fail in non-obvious ways. Change-Id: I3bf38e29151c6066aaf4eba68ae387272d8a82c2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4463 Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in> Reviewed-by: grfn <grfn@gws.fyi> fix(ops/besadii): Stop path.Join from eating our URL 2021-12-19T16:46:00+00:00 Vincent Ambo mail@tazj.in 2021-12-19T16:37:18+00:00 urn:sha1:f8b4029b1744bea77cc3f941d59c09d11f714f47 apparently this chomps away at things inside of fragment strings Change-Id: Ie60d52d101dc4281b3a62c228af076791e1c7928 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4462 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> feat(ops/besadii): Pass Gerrit link to builds as an envvar 2021-12-19T16:27:29+00:00 Vincent Ambo mail@tazj.in 2021-12-19T16:14:47+00:00 urn:sha1:3a2a5ffa9d77e12960ba0349e1810efb068f0701 This makes it possible to annotate builds with a link back to Gerrit. Change-Id: If351785d3b631b96753d41f417ca94bc7a95ac54 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4441 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<feed xmlns="http://www.w3.org/2005/Atom">
<title>depot/ops/besadii, branch refs/r/7126</title>
<subtitle>monorepo for the virus lounge</subtitle>
<id>http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F7126</id>
<link rel="self" href="http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F7126"/>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/"/>
<updated>2022-06-09T15:26:25+00:00</updated>
<entry>
<title>fix(ops/besadii) test trigger.ref against configured branch</title>
<updated>2022-06-09T15:26:25+00:00</updated>
<author>
<name>Åsmund Østvold</name>
<email>asmundo@gmail.com</email>
</author>
<published>2022-06-09T12:36:01+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=2caa50c9bd0f9fad3194c8c1c2653805b038bd0f"/>
<id>urn:sha1:2caa50c9bd0f9fad3194c8c1c2653805b038bd0f</id>
<content type="text"> Before this commit besadii only worked for repos having 'refs/heads/canon' as main branch. Change-Id: Ia2ceb8a720c675be84bc3d81b89338522cea6ebd Reviewed-on: https://cl.tvl.fyi/c/depot/+/5862 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: asmundo <asmundo@gmail.com> </content>
</entry>
<entry>
<title>fix(ops/besadii): Fix output formatting for non-CL builds</title>
<updated>2022-04-26T09:25:03+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2022-04-26T09:21:11+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=96aea320846d3d0d61e9e00d85f58a3efe3f9f82"/>
<id>urn:sha1:96aea320846d3d0d61e9e00d85f58a3efe3f9f82</id>
<content type="text"> Change-Id: Ie9ffb2d287f6c8a1e3ae45a7ad6671b9b8fa9c8a Reviewed-on: https://cl.tvl.fyi/c/depot/+/5505 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: asmundo <asmundo@gmail.com> </content>
</entry>
<entry>
<title>feat(ops/besadii): make text 'cl' posted BuildKite configurable</title>
<updated>2022-01-19T10:31:52+00:00</updated>
<author>
<name>Åsmund Østvold</name>
<email>asmundo@gmail.com</email>
</author>
<published>2022-01-07T10:37:48+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=6e4b0f3cef56443a9780c4ff73466556e4915513"/>
<id>urn:sha1:6e4b0f3cef56443a9780c4ff73466556e4915513</id>
<content type="text"> Some companies do not know the 'cl' term. They do know of 'change' and would maybe not like to introduce one more synonym. This cl introduce an optional entry 'gerritChangeName' in besadii.json. The string has to match `^[a-z0-9]+$` for readability. Change-Id: Id70fcb1e45158869f88bf37669be49b8b8a3b295 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4825 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: asmundo <asmundo@gmail.com> </content>
</entry>
<entry>
<title>feat(besadii): Skip builds of patchsets with no code changes</title>
<updated>2022-01-14T17:35:45+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2022-01-12T14:42:24+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=ee52fbc46c4812921c5e68c16be2542e36d45366"/>
<id>urn:sha1:ee52fbc46c4812921c5e68c16be2542e36d45366</id>
<content type="text"> Currently Gerrit is configured to copy forward the scores of the 'Verified' label if the tree of the commit does not change (e.g. only author information or commit message is modified). Besadii still triggers builds for these patchsets though. With this change it will inspect the (previously ignored) "kind" of the patchset and skip patchsets with the same tree as their predecessor. See Gerrit docs for the semantics of "kind": https://gerrit-review.googlesource.com/Documentation/json.html#patchSet Note that an argument can be made that we should do the exact opposite - stop carrying over 'Verified' at all and always build all patchsets. I think this depends on whether we intend to use commit metadata in CI runs at all. Adding a few people to the review for opinions. Change-Id: I48a96a1ad1e07d92330d84e5cfdc820a39395297 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4867 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Reviewed-by: asmundo <asmundo@gmail.com> Reviewed-by: sterni <sternenseemann@systemli.org> </content>
</entry>
<entry>
<title>fix(ops/besadii) no need to ref CL number in post to Gerrit</title>
<updated>2022-01-12T09:37:01+00:00</updated>
<author>
<name>Åsmund Østvold</name>
<email>asmundo@gmail.com</email>
</author>
<published>2022-01-07T11:57:50+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=d4b997d832b5ba14f31c4a41a9e2555d8a6f7af4"/>
<id>urn:sha1:d4b997d832b5ba14f31c4a41a9e2555d8a6f7af4</id>
<content type="text"> The comment posted to the Gerrit change do not need to contain the CL number as it is given by the context of the Gerrit UI. Change-Id: I172645e7f4d82e2fbebe179578babd42ea29737f Reviewed-on: https://cl.tvl.fyi/c/depot/+/4826 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: asmundo <asmundo@gmail.com> </content>
</entry>
<entry>
<title>style(ops/besadii): run depotfmt</title>
<updated>2021-12-21T14:19:28+00:00</updated>
<author>
<name>sterni</name>
<email>sternenseemann@systemli.org</email>
</author>
<published>2021-12-21T13:55:29+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=7de43fe4eec017790a41f1312c659190baf24f9e"/>
<id>urn:sha1:7de43fe4eec017790a41f1312c659190baf24f9e</id>
<content type="text"> Unclear if this reformat is caused by the channel update or if this file was ignored previously. Change-Id: I3498ab181c7fff1b132419783e33a96f7bebfe42 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4520 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>fix(ops/besadii): fix Gerrit URL format ... again</title>
<updated>2021-12-19T17:08:08+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-12-19T17:05:45+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=eea2dbadd0d38bc017d1fc3fe7b71ac38b6e4bea"/>
<id>urn:sha1:eea2dbadd0d38bc017d1fc3fe7b71ac38b6e4bea</id>
<content type="text"> got into some kind of race with different patchsets of this CL somehow, idk Change-Id: I3dcdb708f141829b866fbd786483710b43ea9824 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4481 Autosubmit: tazjin <mail@tazj.in> Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>fix(ops/besadii): Only set branch to CL when building patchsets</title>
<updated>2021-12-19T16:53:47+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-12-19T16:47:04+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=1d4715781ca8954d8c20e7a7420a7775fd671416"/>
<id>urn:sha1:1d4715781ca8954d8c20e7a7420a7775fd671416</id>
<content type="text"> If we set this for canon, then stuff starts to fail in non-obvious ways. Change-Id: I3bf38e29151c6066aaf4eba68ae387272d8a82c2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4463 Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in> Reviewed-by: grfn <grfn@gws.fyi> </content>
</entry>
<entry>
<title>fix(ops/besadii): Stop path.Join from eating our URL</title>
<updated>2021-12-19T16:46:00+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-12-19T16:37:18+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=f8b4029b1744bea77cc3f941d59c09d11f714f47"/>
<id>urn:sha1:f8b4029b1744bea77cc3f941d59c09d11f714f47</id>
<content type="text"> apparently this chomps away at things inside of fragment strings Change-Id: Ie60d52d101dc4281b3a62c228af076791e1c7928 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4462 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> </content>
</entry>
<entry>
<title>feat(ops/besadii): Pass Gerrit link to builds as an envvar</title>
<updated>2021-12-19T16:27:29+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-12-19T16:14:47+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=3a2a5ffa9d77e12960ba0349e1810efb068f0701"/>
<id>urn:sha1:3a2a5ffa9d77e12960ba0349e1810efb068f0701</id>
<content type="text"> This makes it possible to annotate builds with a link back to Gerrit. Change-Id: If351785d3b631b96753d41f417ca94bc7a95ac54 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4441 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI </content>
</entry>
</feed>