depot/ops/besadii/main.go2, branch refs/r/4014 monorepo for the virus lounge http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F4014 2021-01-30T08:20:45+00:00 chore(3p|nix): Remove typed Go 2021-01-30T08:20:45+00:00 Vincent Ambo mail@tazj.in 2021-01-29T17:14:27+00:00 urn:sha1:8f57ca92bddf8c6a003ee91e737dffad288b8b90 Nobody has actually done any experimentation with typed Go, so we're getting rid of it for now - it's causing annoying IFD during build graph generation. Change-Id: Ibac3dea98ebed1b3ee08acda184d24c500cf695d Reviewed-on: https://cl.tvl.fyi/c/depot/+/2458 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: Profpatsch <mail@profpatsch.de> fix(besadii): Don't add people back to attention set. 2020-08-02T01:18:37+00:00 Luke Granger-Brown hg@lukegb.com 2020-08-01T14:30:25+00:00 urn:sha1:1094e356df316e28d8b7ee8ef9844d0ec7853872 This uses the not very documented ignore_default_attention_set_rules review API. Change-Id: I650777bbbd24a1922f26967fbbd7da06d14b6782 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1513 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> chore(besadii): Stop adding Code-Review label on CLs 2020-07-03T23:17:46+00:00 Vincent Ambo mail@tazj.in 2020-07-01T00:14:10+00:00 urn:sha1:10180e70ec6bde46d307c4b50cfb23184f66ad2d We now use the actual 'Verified' label instead of Code-Review from Buildkite, this workaround is no longer required. This reverts commit d3f9cb0ec398d25a3be01cbc7c9b1ee8716b877f. Change-Id: Ib8c1680eae844cb7b45bf8837acf2af03d4ed344 Reviewed-on: https://cl.tvl.fyi/c/depot/+/909 Reviewed-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI fix(besadii): Do not pass on update values for meta refs 2020-07-01T16:51:50+00:00 Vincent Ambo mail@tazj.in 2020-07-01T00:16:27+00:00 urn:sha1:03076c3977bad32c017810e13adb428411be63cd Before this change, besadii would skip further processing of meta refs (which happen for every CL metadata change), but it would still schedule a build by returning an update - which would then inevitably fail. This change makes besadii skip meta refs the same way it skips non-depot builds, i.e. completely. Move *on* from meta refs, do *not* collect $100. Change-Id: I269d2299f4d3cb1f9c041da8c92fa00ae7794b38 Reviewed-on: https://cl.tvl.fyi/c/depot/+/825 Reviewed-by: eta <eta@theta.eu.org> Reviewed-by: BuildkiteCI Tested-by: BuildkiteCI fix(besadii): Don't log errors for /meta refs 2020-06-30T02:51:45+00:00 Vincent Ambo mail@tazj.in 2020-06-30T00:13:13+00:00 urn:sha1:0380841eb11f6cb200081295107fadbca928bc06 These are updated for all sorts of things and should just be silently ignored by besadii. Change-Id: I0a6de373b21d6bef5fd31d0a1d3f72c501073bba Reviewed-on: https://cl.tvl.fyi/c/depot/+/801 Reviewed-by: BuildkiteCI Reviewed-by: Kane York <rikingcoding@gmail.com> Tested-by: BuildkiteCI feat(besadii): Temporarily add Code-Review labels on CLs 2020-06-29T19:06:37+00:00 Vincent Ambo mail@tazj.in 2020-06-29T17:54:29+00:00 urn:sha1:d3f9cb0ec398d25a3be01cbc7c9b1ee8716b877f Besadii already adds 'Verified'-labels, which are used to signal CI status on CLs, however we don't actually use these labels (yet) which also means that they are not displayed in the Gerrit UI. This change temporarily introduces the Code-Review label *in addition* (with the same values as Verified), providing a build status signal on the CL but without being required for submission. Change-Id: I2c3a37c59aceb426815ad4e400c80ab85be482dd Reviewed-on: https://cl.tvl.fyi/c/depot/+/781 Tested-by: BuildkiteCI Reviewed-by: ericvolp12 <ericvolp12@gmail.com> Reviewed-by: lukegb <lukegb@tvl.fyi> feat(besadii): Implement support for Buildkite's post-command hook 2020-06-29T15:15:19+00:00 Vincent Ambo mail@tazj.in 2020-06-29T02:35:39+00:00 urn:sha1:6d3a9e7b5feb13ae1595854254339686a2fc3c2d This hook is invoked by Buildkite (on the runner) after every build stage. This change adds support in Besadii to run as this hook and update the build status on a Gerrit CL. Change-Id: Ie07a94d9b41645a77681cf42f6969d218abf93c1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/761 Tested-by: BuildkiteCI Reviewed-by: Kane York <rikingcoding@gmail.com> feat(besadii): Propagate Gerrit change ID & patchset to Buildkite 2020-06-29T01:19:51+00:00 Vincent Ambo mail@tazj.in 2020-06-29T01:16:48+00:00 urn:sha1:0bb24ed70013a7f9cfa4eed612decdf4715effba I previously implemented this in a CL that ended up being abandoned, but it turns out we need it for the hook setup, anyways. These environment variables become available during the build and, crucially, to the post-build hooks. Change-Id: Id6c1657947995e8bae1fa7b76184dd8be4c01525 Reviewed-on: https://cl.tvl.fyi/c/depot/+/739 Reviewed-by: Kane York <rikingcoding@gmail.com> feat(besadii): Enable automatic builds for CLs 2020-06-28T17:56:10+00:00 Vincent Ambo mail@tazj.in 2020-06-28T02:37:34+00:00 urn:sha1:15335e7b3dad497dd45633d91db62015b67f08e3 This expands builds to also be triggered for updates to CL refs. The message displayed on Buildkite will contain a link back to the CL (& patchset) from which the build was triggered. Change-Id: Ib36dee454aeb11d623b89c78b384359ee7ea3477 Reviewed-on: https://cl.tvl.fyi/c/depot/+/708 Reviewed-by: ericvolp12 <ericvolp12@gmail.com> Reviewed-by: isomer <isomer@tvl.fyi> refactor(besadii): Rename branchUpdate -> refUpdated 2020-06-28T17:20:22+00:00 Vincent Ambo mail@tazj.in 2020-06-28T01:11:10+00:00 urn:sha1:d3284112f63d9b3ed137c50e04973dc9d4e4e478 The name of the hook this type represents is 'refUpdated'. Since we're adding support for additional hooks, it makes sense to to rename this accordingly. Change-Id: Ia568c85493813f5e754c77d0b993aaf246d3d595 Reviewed-on: https://cl.tvl.fyi/c/depot/+/667 Reviewed-by: lukegb <lukegb@tvl.fyi>
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<feed xmlns="http://www.w3.org/2005/Atom">
<title>depot/ops/besadii/main.go2, branch refs/r/4014</title>
<subtitle>monorepo for the virus lounge</subtitle>
<id>http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F4014</id>
<link rel="self" href="http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F4014"/>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/"/>
<updated>2021-01-30T08:20:45+00:00</updated>
<entry>
<title>chore(3p|nix): Remove typed Go</title>
<updated>2021-01-30T08:20:45+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-01-29T17:14:27+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=8f57ca92bddf8c6a003ee91e737dffad288b8b90"/>
<id>urn:sha1:8f57ca92bddf8c6a003ee91e737dffad288b8b90</id>
<content type="text"> Nobody has actually done any experimentation with typed Go, so we're getting rid of it for now - it's causing annoying IFD during build graph generation. Change-Id: Ibac3dea98ebed1b3ee08acda184d24c500cf695d Reviewed-on: https://cl.tvl.fyi/c/depot/+/2458 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: Profpatsch <mail@profpatsch.de> </content>
</entry>
<entry>
<title>fix(besadii): Don't add people back to attention set.</title>
<updated>2020-08-02T01:18:37+00:00</updated>
<author>
<name>Luke Granger-Brown</name>
<email>hg@lukegb.com</email>
</author>
<published>2020-08-01T14:30:25+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=1094e356df316e28d8b7ee8ef9844d0ec7853872"/>
<id>urn:sha1:1094e356df316e28d8b7ee8ef9844d0ec7853872</id>
<content type="text"> This uses the not very documented ignore_default_attention_set_rules review API. Change-Id: I650777bbbd24a1922f26967fbbd7da06d14b6782 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1513 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>chore(besadii): Stop adding Code-Review label on CLs</title>
<updated>2020-07-03T23:17:46+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2020-07-01T00:14:10+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=10180e70ec6bde46d307c4b50cfb23184f66ad2d"/>
<id>urn:sha1:10180e70ec6bde46d307c4b50cfb23184f66ad2d</id>
<content type="text"> We now use the actual 'Verified' label instead of Code-Review from Buildkite, this workaround is no longer required. This reverts commit d3f9cb0ec398d25a3be01cbc7c9b1ee8716b877f. Change-Id: Ib8c1680eae844cb7b45bf8837acf2af03d4ed344 Reviewed-on: https://cl.tvl.fyi/c/depot/+/909 Reviewed-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>fix(besadii): Do not pass on update values for meta refs</title>
<updated>2020-07-01T16:51:50+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2020-07-01T00:16:27+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=03076c3977bad32c017810e13adb428411be63cd"/>
<id>urn:sha1:03076c3977bad32c017810e13adb428411be63cd</id>
<content type="text"> Before this change, besadii would skip further processing of meta refs (which happen for every CL metadata change), but it would still schedule a build by returning an update - which would then inevitably fail. This change makes besadii skip meta refs the same way it skips non-depot builds, i.e. completely. Move *on* from meta refs, do *not* collect $100. Change-Id: I269d2299f4d3cb1f9c041da8c92fa00ae7794b38 Reviewed-on: https://cl.tvl.fyi/c/depot/+/825 Reviewed-by: eta <eta@theta.eu.org> Reviewed-by: BuildkiteCI Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>fix(besadii): Don't log errors for /meta refs</title>
<updated>2020-06-30T02:51:45+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2020-06-30T00:13:13+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=0380841eb11f6cb200081295107fadbca928bc06"/>
<id>urn:sha1:0380841eb11f6cb200081295107fadbca928bc06</id>
<content type="text"> These are updated for all sorts of things and should just be silently ignored by besadii. Change-Id: I0a6de373b21d6bef5fd31d0a1d3f72c501073bba Reviewed-on: https://cl.tvl.fyi/c/depot/+/801 Reviewed-by: BuildkiteCI Reviewed-by: Kane York <rikingcoding@gmail.com> Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>feat(besadii): Temporarily add Code-Review labels on CLs</title>
<updated>2020-06-29T19:06:37+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2020-06-29T17:54:29+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=d3f9cb0ec398d25a3be01cbc7c9b1ee8716b877f"/>
<id>urn:sha1:d3f9cb0ec398d25a3be01cbc7c9b1ee8716b877f</id>
<content type="text"> Besadii already adds 'Verified'-labels, which are used to signal CI status on CLs, however we don't actually use these labels (yet) which also means that they are not displayed in the Gerrit UI. This change temporarily introduces the Code-Review label *in addition* (with the same values as Verified), providing a build status signal on the CL but without being required for submission. Change-Id: I2c3a37c59aceb426815ad4e400c80ab85be482dd Reviewed-on: https://cl.tvl.fyi/c/depot/+/781 Tested-by: BuildkiteCI Reviewed-by: ericvolp12 <ericvolp12@gmail.com> Reviewed-by: lukegb <lukegb@tvl.fyi> </content>
</entry>
<entry>
<title>feat(besadii): Implement support for Buildkite's post-command hook</title>
<updated>2020-06-29T15:15:19+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2020-06-29T02:35:39+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=6d3a9e7b5feb13ae1595854254339686a2fc3c2d"/>
<id>urn:sha1:6d3a9e7b5feb13ae1595854254339686a2fc3c2d</id>
<content type="text"> This hook is invoked by Buildkite (on the runner) after every build stage. This change adds support in Besadii to run as this hook and update the build status on a Gerrit CL. Change-Id: Ie07a94d9b41645a77681cf42f6969d218abf93c1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/761 Tested-by: BuildkiteCI Reviewed-by: Kane York <rikingcoding@gmail.com> </content>
</entry>
<entry>
<title>feat(besadii): Propagate Gerrit change ID & patchset to Buildkite</title>
<updated>2020-06-29T01:19:51+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2020-06-29T01:16:48+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=0bb24ed70013a7f9cfa4eed612decdf4715effba"/>
<id>urn:sha1:0bb24ed70013a7f9cfa4eed612decdf4715effba</id>
<content type="text"> I previously implemented this in a CL that ended up being abandoned, but it turns out we need it for the hook setup, anyways. These environment variables become available during the build and, crucially, to the post-build hooks. Change-Id: Id6c1657947995e8bae1fa7b76184dd8be4c01525 Reviewed-on: https://cl.tvl.fyi/c/depot/+/739 Reviewed-by: Kane York <rikingcoding@gmail.com> </content>
</entry>
<entry>
<title>feat(besadii): Enable automatic builds for CLs</title>
<updated>2020-06-28T17:56:10+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2020-06-28T02:37:34+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=15335e7b3dad497dd45633d91db62015b67f08e3"/>
<id>urn:sha1:15335e7b3dad497dd45633d91db62015b67f08e3</id>
<content type="text"> This expands builds to also be triggered for updates to CL refs. The message displayed on Buildkite will contain a link back to the CL (& patchset) from which the build was triggered. Change-Id: Ib36dee454aeb11d623b89c78b384359ee7ea3477 Reviewed-on: https://cl.tvl.fyi/c/depot/+/708 Reviewed-by: ericvolp12 <ericvolp12@gmail.com> Reviewed-by: isomer <isomer@tvl.fyi> </content>
</entry>
<entry>
<title>refactor(besadii): Rename branchUpdate -> refUpdated</title>
<updated>2020-06-28T17:20:22+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2020-06-28T01:11:10+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=d3284112f63d9b3ed137c50e04973dc9d4e4e478"/>
<id>urn:sha1:d3284112f63d9b3ed137c50e04973dc9d4e4e478</id>
<content type="text"> The name of the hook this type represents is 'refUpdated'. Since we're adding support for additional hooks, it makes sense to to rename this accordingly. Change-Id: Ia568c85493813f5e754c77d0b993aaf246d3d595 Reviewed-on: https://cl.tvl.fyi/c/depot/+/667 Reviewed-by: lukegb <lukegb@tvl.fyi> </content>
</entry>
</feed>