depot/nix/readTree, branch refs/r/5249 monorepo for the virus lounge http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F5249 2022-10-10T17:42:48+00:00 feat(nix/readTree): Handle a builtins w/o scopedImport 2022-10-10T17:42:48+00:00 Griffin Smith root@gws.fyi 2022-10-10T02:04:37+00:00 urn:sha1:b0547ccfa5e74cf21e813cd18f64ef62f1bf3734 We (might) not want to implement scopedImport in tvix given it's considered a bit of a misfeature; this makes readTree work with a `builtins` set that doesn't have it (and if we decide we do want tvix to have scopedImport, we can revert this pretty easily). Change-Id: Ia3bbc847514672063a607d977ce167d489fa1131 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6915 Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI refactor(readTree): deprecate meta.targets for meta.ci.targets 2022-02-07T15:13:52+00:00 Vincent Ambo mail@tazj.in 2022-02-07T10:46:00+00:00 urn:sha1:8b8c98380e85b2057a3c35ce3d76879fab4266b0 This means that we use the meta.ci attribute more consistently. The meta.targets attribute is still read, but prints a big, red warning telling people to migrate to the new one. Fixes b/176 Change-Id: Ifb4452f529cfc6bbd5018ad7374cac1c83b10045 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5238 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> refactor(nix): Move `mkLabel` from buildkite to readTree 2022-02-07T15:13:52+00:00 Vincent Ambo mail@tazj.in 2022-02-07T10:24:18+00:00 urn:sha1:3bde42586089a28a49dc063c2e639194211cb9af This function is more generically useful than just for pipeline construction. A subsequent commit will use it inside of readTree itself. Change-Id: I5eabd6f659726484667e060958865dddbc205762 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5237 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> fix(nix/readTree): Use overrideAttrs with derivations 2022-02-02T13:36:58+00:00 Vincent Ambo mail@tazj.in 2022-02-02T10:19:04+00:00 urn:sha1:ba7197c271d54fd806970738e883b39c8ae1a3a9 Derivations that support overrideAttrs now have their readTree markers merged in using it, as passthru attributes. This makes the significant difference that overriding readTree targets using `overrideAttrs` keeps their readTree data intact. Change-Id: Ieef635f048781bf4782c1a28532b89a66d9ca24d Reviewed-on: https://cl.tvl.fyi/c/depot/+/5186 Tested-by: BuildkiteCI Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com> Autosubmit: tazjin <tazjin@tvl.su> style: format entire depot with nixpkgs-fmt 2022-01-31T16:11:53+00:00 Vincent Ambo mail@tazj.in 2022-01-30T16:06:58+00:00 urn:sha1:aa122cbae78ce97d60c0c98ba14df753d97e40b1 This CL can be used to compare the style of nixpkgs-fmt against other formatters (nixpkgs, alejandra). Change-Id: I87c6abff6bcb546b02ead15ad0405f81e01b6d9e Reviewed-on: https://cl.tvl.fyi/c/depot/+/4397 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: wpcarro <wpcarro@gmail.com> Reviewed-by: Profpatsch <mail@profpatsch.de> Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: cynthia <cynthia@tvl.fyi> Reviewed-by: edef <edef@edef.eu> Reviewed-by: eta <tvl@eta.st> Reviewed-by: grfn <grfn@gws.fyi> docs(nix/readTree): Tweak grammar of docs for `gather` 2021-12-16T21:14:15+00:00 Griffin Smith grfn@gws.fyi 2021-12-16T21:06:22+00:00 urn:sha1:ca56cb2d9f3cf325cec61a394e16a8bdaedba4e2 This seemed to be missing a word previously. Change-Id: Ifa860051d6b692a626dbaddbaee44b761f2274ff Reviewed-on: https://cl.tvl.fyi/c/depot/+/4386 Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> fix(readTree): Apply .skip-subtree to Nix-file children as well 2021-12-08T18:22:00+00:00 Vincent Ambo mail@tazj.in 2021-12-07T09:54:50+00:00 urn:sha1:2fa157ccd6e1aa8a0bdeda3a9b720bc6b8f5910e This behaviour was previously confusing, since readTree's data structure treats children from Nix files and directories as identical but only one of them would be affected by .skip-subtree The "subtree" to be skipped here refers to all children of the structure. Change-Id: Idf596c9823f09cc2acf49523916bde4b801b8519 refactor(readTree): Move 'drvTargets' into readTree 2021-11-23T14:42:08+00:00 Vincent Ambo mail@tazj.in 2021-11-23T13:31:17+00:00 urn:sha1:4f1249e46fb816cfd299ae27385a63746f914c3f This function is also generally useful for readTree consumers that have the concept of subtargets. Change-Id: Ic7fc03380dec6953fb288763a28e50ab3624d233 refactor(readTree): Move 'gather' into readTree itself 2021-11-23T14:42:08+00:00 Vincent Ambo mail@tazj.in 2021-11-23T12:00:27+00:00 urn:sha1:5cad3f7b81b1460aeceb40936e0c7dcb029936a6 Discovering CI targets is relevant to all readTree consumers and this logic is not TVL-specific. Change-Id: I81ed3d3f76a6c36119f04bee28ca995a013f0e35 refactor(readTree): Move copy of 'fix' into readTree 2021-11-23T12:02:53+00:00 Vincent Ambo mail@tazj.in 2021-11-23T11:39:20+00:00 urn:sha1:a2be05faa4043c225581090846c52718812fac8f This is often used when bootstrapping a repository with readTree, before lib is available. Having this definition in readTree is more convenient than copy&pasting it around to callsites. Change-Id: I6d5d27ed142bea704843fe289ad2674be8c4d360
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<feed xmlns="http://www.w3.org/2005/Atom">
<title>depot/nix/readTree, branch refs/r/5249</title>
<subtitle>monorepo for the virus lounge</subtitle>
<id>http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F5249</id>
<link rel="self" href="http://code.tvl.fyi/depot/atom?h=refs%2Fr%2F5249"/>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/"/>
<updated>2022-10-10T17:42:48+00:00</updated>
<entry>
<title>feat(nix/readTree): Handle a builtins w/o scopedImport</title>
<updated>2022-10-10T17:42:48+00:00</updated>
<author>
<name>Griffin Smith</name>
<email>root@gws.fyi</email>
</author>
<published>2022-10-10T02:04:37+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=b0547ccfa5e74cf21e813cd18f64ef62f1bf3734"/>
<id>urn:sha1:b0547ccfa5e74cf21e813cd18f64ef62f1bf3734</id>
<content type="text"> We (might) not want to implement scopedImport in tvix given it's considered a bit of a misfeature; this makes readTree work with a `builtins` set that doesn't have it (and if we decide we do want tvix to have scopedImport, we can revert this pretty easily). Change-Id: Ia3bbc847514672063a607d977ce167d489fa1131 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6915 Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI </content>
</entry>
<entry>
<title>refactor(readTree): deprecate meta.targets for meta.ci.targets</title>
<updated>2022-02-07T15:13:52+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2022-02-07T10:46:00+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=8b8c98380e85b2057a3c35ce3d76879fab4266b0"/>
<id>urn:sha1:8b8c98380e85b2057a3c35ce3d76879fab4266b0</id>
<content type="text"> This means that we use the meta.ci attribute more consistently. The meta.targets attribute is still read, but prints a big, red warning telling people to migrate to the new one. Fixes b/176 Change-Id: Ifb4452f529cfc6bbd5018ad7374cac1c83b10045 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5238 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> </content>
</entry>
<entry>
<title>refactor(nix): Move `mkLabel` from buildkite to readTree</title>
<updated>2022-02-07T15:13:52+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2022-02-07T10:24:18+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=3bde42586089a28a49dc063c2e639194211cb9af"/>
<id>urn:sha1:3bde42586089a28a49dc063c2e639194211cb9af</id>
<content type="text"> This function is more generically useful than just for pipeline construction. A subsequent commit will use it inside of readTree itself. Change-Id: I5eabd6f659726484667e060958865dddbc205762 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5237 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> </content>
</entry>
<entry>
<title>fix(nix/readTree): Use overrideAttrs with derivations</title>
<updated>2022-02-02T13:36:58+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2022-02-02T10:19:04+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=ba7197c271d54fd806970738e883b39c8ae1a3a9"/>
<id>urn:sha1:ba7197c271d54fd806970738e883b39c8ae1a3a9</id>
<content type="text"> Derivations that support overrideAttrs now have their readTree markers merged in using it, as passthru attributes. This makes the significant difference that overriding readTree targets using `overrideAttrs` keeps their readTree data intact. Change-Id: Ieef635f048781bf4782c1a28532b89a66d9ca24d Reviewed-on: https://cl.tvl.fyi/c/depot/+/5186 Tested-by: BuildkiteCI Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com> Autosubmit: tazjin <tazjin@tvl.su> </content>
</entry>
<entry>
<title>style: format entire depot with nixpkgs-fmt</title>
<updated>2022-01-31T16:11:53+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2022-01-30T16:06:58+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=aa122cbae78ce97d60c0c98ba14df753d97e40b1"/>
<id>urn:sha1:aa122cbae78ce97d60c0c98ba14df753d97e40b1</id>
<content type="text"> This CL can be used to compare the style of nixpkgs-fmt against other formatters (nixpkgs, alejandra). Change-Id: I87c6abff6bcb546b02ead15ad0405f81e01b6d9e Reviewed-on: https://cl.tvl.fyi/c/depot/+/4397 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: wpcarro <wpcarro@gmail.com> Reviewed-by: Profpatsch <mail@profpatsch.de> Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: cynthia <cynthia@tvl.fyi> Reviewed-by: edef <edef@edef.eu> Reviewed-by: eta <tvl@eta.st> Reviewed-by: grfn <grfn@gws.fyi> </content>
</entry>
<entry>
<title>docs(nix/readTree): Tweak grammar of docs for `gather`</title>
<updated>2021-12-16T21:14:15+00:00</updated>
<author>
<name>Griffin Smith</name>
<email>grfn@gws.fyi</email>
</author>
<published>2021-12-16T21:06:22+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=ca56cb2d9f3cf325cec61a394e16a8bdaedba4e2"/>
<id>urn:sha1:ca56cb2d9f3cf325cec61a394e16a8bdaedba4e2</id>
<content type="text"> This seemed to be missing a word previously. Change-Id: Ifa860051d6b692a626dbaddbaee44b761f2274ff Reviewed-on: https://cl.tvl.fyi/c/depot/+/4386 Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> </content>
</entry>
<entry>
<title>fix(readTree): Apply .skip-subtree to Nix-file children as well</title>
<updated>2021-12-08T18:22:00+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-12-07T09:54:50+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=2fa157ccd6e1aa8a0bdeda3a9b720bc6b8f5910e"/>
<id>urn:sha1:2fa157ccd6e1aa8a0bdeda3a9b720bc6b8f5910e</id>
<content type="text"> This behaviour was previously confusing, since readTree's data structure treats children from Nix files and directories as identical but only one of them would be affected by .skip-subtree The "subtree" to be skipped here refers to all children of the structure. Change-Id: Idf596c9823f09cc2acf49523916bde4b801b8519 </content>
</entry>
<entry>
<title>refactor(readTree): Move 'drvTargets' into readTree</title>
<updated>2021-11-23T14:42:08+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-11-23T13:31:17+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=4f1249e46fb816cfd299ae27385a63746f914c3f"/>
<id>urn:sha1:4f1249e46fb816cfd299ae27385a63746f914c3f</id>
<content type="text"> This function is also generally useful for readTree consumers that have the concept of subtargets. Change-Id: Ic7fc03380dec6953fb288763a28e50ab3624d233 </content>
</entry>
<entry>
<title>refactor(readTree): Move 'gather' into readTree itself</title>
<updated>2021-11-23T14:42:08+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-11-23T12:00:27+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=5cad3f7b81b1460aeceb40936e0c7dcb029936a6"/>
<id>urn:sha1:5cad3f7b81b1460aeceb40936e0c7dcb029936a6</id>
<content type="text"> Discovering CI targets is relevant to all readTree consumers and this logic is not TVL-specific. Change-Id: I81ed3d3f76a6c36119f04bee28ca995a013f0e35 </content>
</entry>
<entry>
<title>refactor(readTree): Move copy of 'fix' into readTree</title>
<updated>2021-11-23T12:02:53+00:00</updated>
<author>
<name>Vincent Ambo</name>
<email>mail@tazj.in</email>
</author>
<published>2021-11-23T11:39:20+00:00</published>
<link rel="alternate" type="text/html" href="http://code.tvl.fyi/commit/?id=a2be05faa4043c225581090846c52718812fac8f"/>
<id>urn:sha1:a2be05faa4043c225581090846c52718812fac8f</id>
<content type="text"> This is often used when bootstrapping a repository with readTree, before lib is available. Having this definition in readTree is more convenient than copy&pasting it around to callsites. Change-Id: I6d5d27ed142bea704843fe289ad2674be8c4d360 </content>
</entry>
</feed>